Issue 6558048: Addressed xcode analysis complaints

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6558048: Addressed xcode analysis complaints (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by robertphillips

Modified:
13 years ago

Reviewers:
bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 3

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -9 lines)			Patch
M	src/core/SkBitmap.cpp	View	1 chunk	+1 line, -1 line	1 comment	Download
M	src/gpu/GrTextureAccess.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLSL.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	src/views/mac/SkNSView.mm	View	1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

robertphillips

http://codereview.appspot.com/6558048/diff/1/src/core/SkBitmap.cpp File src/core/SkBitmap.cpp (right): http://codereview.appspot.com/6558048/diff/1/src/core/SkBitmap.cpp#newcode1165 src/core/SkBitmap.cpp:1165: unsigned rowBytes; The assigned value could never be read

13 years ago (2012-09-24 13:54:13 UTC) #1

bsalomon

lgtm https://codereview.appspot.com/6558048/diff/1/src/views/mac/SkNSView.mm File src/views/mac/SkNSView.mm (left): https://codereview.appspot.com/6558048/diff/1/src/views/mac/SkNSView.mm#oldcode9 src/views/mac/SkNSView.mm:9: #import "SkNSView.h"s Woah.. how did this compile?

13 years ago (2012-09-24 14:07:39 UTC) #4

robertphillips

13 years ago (2012-09-24 14:29:15 UTC) #5

committed as r5646

https://codereview.appspot.com/6558048/diff/1/src/views/mac/SkNSView.mm
File src/views/mac/SkNSView.mm (left):

https://codereview.appspot.com/6558048/diff/1/src/views/mac/SkNSView.mm#oldcode9
src/views/mac/SkNSView.mm:9: #import "SkNSView.h"s
It must be a very common error. The warning was something "extra chars after
#import".

Expand All Messages | Collapse All Messages