Issue 6558043: code review 6558043: cmd/6g: fix internal error with SSE registers.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6558043: code review 6558043: cmd/6g: fix internal error with SSE registers. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by remyoudompheng

Modified:
11 years, 7 months ago

Reviewers:

CC:
rsc, golang-dev, remy_archlinux.org

Visibility:
Public.

Description

cmd/6g: fix internal error with SSE registers. Revision 63f7abcae015 introduced a bug caused by code assuming registers started at X5, not X0. Fixes issue 4138.

Patch Set 2 : diff -r bbb1a6dfcd58 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r bbb1a6dfcd58 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r bbb1a6dfcd58 https://go.googlecode.com/hg/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -5 lines)			Patch
	M	src/cmd/6g/reg.c	View	1 2 3	2 chunks	+5 lines, -5 lines	0 comments	Download
	A	test/fixedbugs/bug453.go	View	1 2	1 chunk	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 7 months ago (2012-09-23 15:08:42 UTC) #1

rsc

LGTM http://codereview.appspot.com/6558043/diff/1002/src/cmd/6g/reg.c File src/cmd/6g/reg.c (right): http://codereview.appspot.com/6558043/diff/1002/src/cmd/6g/reg.c#newcode1603 src/cmd/6g/reg.c:1603: * 21 X5 (FREGMIN) Can you make this ...

11 years, 7 months ago (2012-09-23 16:13:21 UTC) #2

remyoudompheng

11 years, 7 months ago (2012-09-23 16:22:13 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=cd6459c9f26e ***

cmd/6g: fix internal error with SSE registers.

Revision 63f7abcae015 introduced a bug caused by
code assuming registers started at X5, not X0.

Fixes issue 4138.

R=rsc
CC=golang-dev, remy
http://codereview.appspot.com/6558043

http://codereview.appspot.com/6558043/diff/1002/src/cmd/6g/reg.c
File src/cmd/6g/reg.c (right):

http://codereview.appspot.com/6558043/diff/1002/src/cmd/6g/reg.c#newcode1603
src/cmd/6g/reg.c:1603: *	21	X5 (FREGMIN)
On 2012/09/23 16:13:21, rsc wrote:
> Can you make this 16 and X0 ?
> The comment makes it sound like below X5 is not supposed to be handled, but
this
> code does handle it (and rightly so, I think).

Done.

Expand All Messages | Collapse All Messages