Issue 6557044: code review 6557044: cmd/6g: use all 16 float registers, optimize float moves

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6557044: code review 6557044: cmd/6g: use all 16 float registers, optimize float moves (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by rsc

Modified:
11 years, 7 months ago

Reviewers:
mtj1, ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

cmd/6g: use all 16 float registers, optimize float moves Fixes issue 2446.

Patch Set 1 #

Patch Set 2 : diff -r a3fb97af739b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a3fb97af739b https://go.googlecode.com/hg/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -13 lines)			Patch
M	src/cmd/6g/gsubr.c	View	1 2	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/cmd/6g/peep.c	View	1	4 chunks	+46 lines, -8 lines	0 comments	Download
M	src/cmd/6g/reg.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/6l/6.out.h	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 7 months ago (2012-09-21 17:39:08 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=63f7abcae015 *** cmd/6g: use all 16 float registers, optimize float moves Fixes ...

11 years, 7 months ago (2012-09-21 17:39:12 UTC) #2

mtj1

11 years, 7 months ago (2012-09-21 18:46:37 UTC) #4

Thank you. Thank you. Truly, thank you!

On Fri, Sep 21, 2012 at 2:19 PM,  <ken@google.com> wrote:
>
> lgtm
>
>
>
> https://codereview.appspot.com/6557044/


-- 
Michael T. Jones | Chief Technology Advocate  | mtj@google.com |  +1
650-335-5765

Expand All Messages | Collapse All Messages