Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(843)

Issue 6552059: code review 6552059: cmd/5g: fix register opt bug (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by rsc
Modified:
11 years, 7 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

cmd/5g: fix register opt bug The width was not being set on the address, which meant that the optimizer could not find variables that overlapped with it and mark them as having had their address taken. This let to the compiler believing variables had been set but never used and then optimizing away the set. Fixes issue 4129.

Patch Set 1 #

Patch Set 2 : diff -r a1dbdb805e2e https://code.google.com/p/go/ #

Patch Set 3 : diff -r a1dbdb805e2e https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -8 lines) Patch
M src/cmd/5g/gsubr.c View 1 2 chunks +8 lines, -0 lines 0 comments Download
M src/cmd/5g/reg.c View 1 11 chunks +34 lines, -3 lines 0 comments Download
M src/cmd/6g/reg.c View 1 2 3 chunks +7 lines, -3 lines 0 comments Download
M src/cmd/8g/reg.c View 1 2 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 7 months ago (2012-09-22 14:01:33 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=d91e3e7106aa *** cmd/5g: fix register opt bug The width was not being ...
11 years, 7 months ago (2012-09-22 14:01:39 UTC) #2
ken3
11 years, 7 months ago (2012-09-22 14:06:48 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b