Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4194)

Issue 6549054: code review 6549054: test: expand run.go's errorcheck, make clear which bugs run (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by rsc
Modified:
11 years, 6 months ago
Reviewers:
r
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

test: expand run.go's errorcheck, make clear which bugs run Today, if run.go doesn't understand a test header line it just ignores the test, making it too easy to write or edit tests that are not actually being run. - expand errorcheck to accept flags, so that bounds.go and escape*.go can run. - create a whitelist of skippable tests in run.go; skipping others is an error. - mark all skipped tests at top of file. Update issue 4139.

Patch Set 1 #

Patch Set 2 : diff -r a203e3118c5d https://code.google.com/p/go/ #

Patch Set 3 : diff -r a203e3118c5d https://code.google.com/p/go/ #

Patch Set 4 : diff -r cd6459c9f26e https://code.google.com/p/go/ #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -11 lines) Patch
M test/args.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/bounds.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/bugs/bug395.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/bugs/bug434.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/ddd3.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/dwarf/main.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/escape2.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/escape4.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug083.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/fixedbugs/bug133.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/fixedbugs/bug160.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/fixedbugs/bug191.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/fixedbugs/bug248.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/fixedbugs/bug302.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/fixedbugs/bug313.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/fixedbugs/bug322.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/fixedbugs/bug324.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/fixedbugs/bug345.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/fixedbugs/bug367.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/fixedbugs/bug369.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/fixedbugs/bug382.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/fixedbugs/bug385_32.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/fixedbugs/bug385_64.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/fixedbugs/bug414.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/fixedbugs/bug424.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/fixedbugs/bug429.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/fixedbugs/bug437.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/import3.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/import4.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/index.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/interface/embed1.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/interface/private.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/interface/recursive2.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/linkx.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/method4.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/nul1.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/rotate.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/run.go View 1 2 7 chunks +95 lines, -7 lines 1 comment Download
M test/sigchld.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/sinit.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/testlib View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 6
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years, 6 months ago (2012-09-23 16:58:36 UTC) #1
bradfitz
LGTM
11 years, 6 months ago (2012-09-23 17:07:29 UTC) #2
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=29cff1e8de4e *** test: expand run.go's errorcheck, make clear which bugs run Today, ...
11 years, 6 months ago (2012-09-23 17:16:18 UTC) #3
r
http://codereview.appspot.com/6549054/diff/2002/test/run.go File test/run.go (right): http://codereview.appspot.com/6549054/diff/2002/test/run.go#newcode11 test/run.go:11: package main this thing really could use a proper ...
11 years, 6 months ago (2012-09-23 19:13:24 UTC) #4
rsc
> http://codereview.appspot.com/6549054/diff/2002/test/run.go#newcode11 > test/run.go:11: package main > this thing really could use a proper explanation ...
11 years, 6 months ago (2012-09-23 19:28:36 UTC) #5
r
11 years, 6 months ago (2012-09-23 19:31:07 UTC) #6
as the original designer of the modem noise, i'm thrilled to see it going away.

-rob
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b