Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(179)

Issue 6548047: code review 6548047: bufio: Implement io.WriterTo for (*Reader) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by chaten
Modified:
11 years, 6 months ago
Reviewers:
CC:
dfc, nigeltao, rsc, bradfitz, rog, golang-dev
Visibility:
Public.

Description

bufio: Implement io.WriterTo for (*Reader) This is part 1 of 2 for issue 4028 benchmark old ns/op new ns/op delta BenchmarkReaderCopyOptimal 33495 9849 -70.60% BenchmarkReaderCopyUnoptimal 70631 27041 -61.72% BenchmarkReaderCopyOldImpl 51407 52970 +3.04% Update issue 4028

Patch Set 1 #

Patch Set 2 : diff -r 90c9121e26c3 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 90c9121e26c3 https://code.google.com/p/go/ #

Total comments: 22

Patch Set 4 : diff -r 84b4a0bb424a https://code.google.com/p/go/ #

Patch Set 5 : diff -r 84b4a0bb424a https://code.google.com/p/go/ #

Total comments: 4

Patch Set 6 : diff -r 84b4a0bb424a https://code.google.com/p/go/ #

Total comments: 4

Patch Set 7 : diff -r bb1ad0db059a https://code.google.com/p/go/ #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -0 lines) Patch
M src/pkg/bufio/bufio.go View 1 2 3 4 5 6 1 chunk +35 lines, -0 lines 0 comments Download
M src/pkg/bufio/bufio_test.go View 1 2 3 4 5 6 1 chunk +98 lines, -0 lines 2 comments Download

Messages

Total messages: 19
chaten
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years, 6 months ago (2012-09-21 08:51:30 UTC) #1
chaten
On 2012/09/21 08:51:30, chaten wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...
11 years, 6 months ago (2012-09-21 08:52:37 UTC) #2
dfc
Updates issue 4028. On Fri, Sep 21, 2012 at 6:52 PM, <mchaten@gmail.com> wrote: > On ...
11 years, 6 months ago (2012-09-21 08:55:45 UTC) #3
nigeltao
On 21 September 2012 18:55, Dave Cheney <dave@cheney.net> wrote: > Updates issue 4028. Drop the ...
11 years, 6 months ago (2012-09-24 04:03:13 UTC) #4
rsc
http://codereview.appspot.com/6548047/diff/3/src/pkg/bufio/bufio.go File src/pkg/bufio/bufio.go (right): http://codereview.appspot.com/6548047/diff/3/src/pkg/bufio/bufio.go#newcode378 src/pkg/bufio/bufio.go:378: // WriteTo first writes the contents of the buffer ...
11 years, 6 months ago (2012-09-24 15:34:08 UTC) #5
bradfitz
https://codereview.appspot.com/6548047/diff/3/src/pkg/bufio/bufio.go File src/pkg/bufio/bufio.go (right): https://codereview.appspot.com/6548047/diff/3/src/pkg/bufio/bufio.go#newcode378 src/pkg/bufio/bufio.go:378: // WriteTo first writes the contents of the buffer ...
11 years, 6 months ago (2012-09-24 15:41:53 UTC) #6
rsc
Sure.
11 years, 6 months ago (2012-09-24 16:49:29 UTC) #7
chaten
http://codereview.appspot.com/6548047/diff/3/src/pkg/bufio/bufio.go File src/pkg/bufio/bufio.go (right): http://codereview.appspot.com/6548047/diff/3/src/pkg/bufio/bufio.go#newcode378 src/pkg/bufio/bufio.go:378: // WriteTo first writes the contents of the buffer ...
11 years, 6 months ago (2012-09-25 04:42:06 UTC) #8
chaten
Hello dave@cheney.net, nigeltao@golang.org, rsc@golang.org, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 6 months ago (2012-09-25 05:03:38 UTC) #9
chaten
Hello dave@cheney.net, nigeltao@golang.org, rsc@golang.org, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 6 months ago (2012-09-25 05:04:02 UTC) #10
rog
http://codereview.appspot.com/6548047/diff/16001/src/pkg/bufio/bufio.go File src/pkg/bufio/bufio.go (right): http://codereview.appspot.com/6548047/diff/16001/src/pkg/bufio/bufio.go#newcode379 src/pkg/bufio/bufio.go:379: d http://codereview.appspot.com/6548047/diff/16001/src/pkg/bufio/bufio.go#newcode384 src/pkg/bufio/bufio.go:384: } i wonder if it might ...
11 years, 6 months ago (2012-09-25 11:08:37 UTC) #11
chaten
http://codereview.appspot.com/6548047/diff/16001/src/pkg/bufio/bufio.go File src/pkg/bufio/bufio.go (right): http://codereview.appspot.com/6548047/diff/16001/src/pkg/bufio/bufio.go#newcode384 src/pkg/bufio/bufio.go:384: } On 2012/09/25 11:08:38, rog wrote: > i wonder ...
11 years, 6 months ago (2012-09-26 05:52:26 UTC) #12
chaten
Hello dave@cheney.net, nigeltao@golang.org, rsc@golang.org, bradfitz@golang.org, rogpeppe@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 6 months ago (2012-09-26 05:58:16 UTC) #13
rsc
looks fine to me. nigel or rog?
11 years, 6 months ago (2012-09-26 18:43:48 UTC) #14
nigeltao
LGTM. Please change the changelist description: s/Issue/issue/ in "Update Issue 4028". It'd also be nice ...
11 years, 6 months ago (2012-09-27 01:37:45 UTC) #15
nigeltao
https://codereview.appspot.com/6548047/diff/11002/src/pkg/bufio/bufio.go File src/pkg/bufio/bufio.go (right): https://codereview.appspot.com/6548047/diff/11002/src/pkg/bufio/bufio.go#newcode378 src/pkg/bufio/bufio.go:378: // WriteTo implements io.WriterTo Add a full stop. https://codereview.appspot.com/6548047/diff/11002/src/pkg/bufio/bufio.go#newcode406 ...
11 years, 6 months ago (2012-09-27 01:38:13 UTC) #16
chaten
Hello dave@cheney.net, nigeltao@golang.org, rsc@golang.org, bradfitz@golang.org, rogpeppe@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 6 months ago (2012-09-27 04:27:37 UTC) #17
nigeltao
I'll make a couple of fixes and submit... https://codereview.appspot.com/6548047/diff/16002/src/pkg/bufio/bufio_test.go File src/pkg/bufio/bufio_test.go (right): https://codereview.appspot.com/6548047/diff/16002/src/pkg/bufio/bufio_test.go#newcode769 src/pkg/bufio/bufio_test.go:769: input[i] ...
11 years, 6 months ago (2012-09-27 06:29:17 UTC) #18
nigeltao
11 years, 6 months ago (2012-09-27 06:31:25 UTC) #19
*** Submitted as http://code.google.com/p/go/source/detail?r=2c0e435aa879 ***

bufio: Implement io.WriterTo for (*Reader)

This is part 1 of 2 for issue 4028

benchmark                       old ns/op    new ns/op    delta
BenchmarkReaderCopyOptimal          33495         9849  -70.60%
BenchmarkReaderCopyUnoptimal        70631        27041  -61.72%
BenchmarkReaderCopyOldImpl          51407        52970   +3.04%

Update issue 4028

R=dave, nigeltao, rsc, bradfitz, rogpeppe
CC=golang-dev
http://codereview.appspot.com/6548047

Committer: Nigel Tao <nigeltao@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b