Issue 6546049: Prevent LinearRegression from dividing by zero

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6546049: Prevent LinearRegression from dividing by zero (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by Stephen White

Modified:
12 years, 2 months ago

Reviewers:
bungeman

CC:
skia-reviews_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

.. so the GenerateBenchGraphs step doesn't blow up if the data is all zeroes. Also leave a skeletal main in bench_util.py as some semblance of a test case.

Patch Set 1 #

Patch Set 2 : remove spurious semicolon and unrelated file change #

Patch Set 3 : use denom in one more place #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -4 lines)			Patch
	M	bench/bench_util.py	View	1 2	2 chunks	+15 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Stephen White

12 years, 2 months ago (2012-09-20 19:54:27 UTC) #3

On 2012/09/20 19:03:49, bungeman wrote:
> LGTM

Landed as https://code.google.com/p/skia/source/detail?r=5615.  Closing.

Expand All Messages | Collapse All Messages