Issue 6545052: code review 6545052: codereview.py: Fix crash on auth error handling.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6545052: code review 6545052: codereview.py: Fix crash on auth error handling.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by luriel

Modified:
11 years, 6 months ago

Reviewers:
adg

CC:
golang-dev, adg

Visibility:
Public.

Description

codereview.py: Fix crash on auth error handling. In recent Python versions .reason is a read-only property that simply gives you the msg value. Fixes issue 4024

Patch Set 1 #

Patch Set 2 : diff -r 90c9121e26c3 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 90c9121e26c3 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 90c9121e26c3 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 90c9121e26c3 https://go.googlecode.com/hg/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -9 lines)			Patch
	M	lib/codereview/codereview.py	View	1 2	2 chunks	+11 lines, -9 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

luriel

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 7 months ago (2012-09-21 11:42:51 UTC) #1

luriel

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 7 months ago (2012-09-22 05:46:36 UTC) #2

minux1

11 years, 6 months ago (2012-10-10 16:24:09 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=26a110c84106 ***

codereview.py: Fix crash on auth error handling.

In recent Python versions .reason is a read-only property that simply gives you
the msg value.

Fixes issue 4024

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/6545052

Committer: Shenghou Ma <minux.ma@gmail.com>

Expand All Messages | Collapse All Messages