Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1406)

Issue 6543046: Corrects beamed cross-staff stems' pure heights

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by MikeSol
Modified:
11 years, 7 months ago
Reviewers:
Keith
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Corrects beamed cross-staff stems' pure heights An incorrect subtraction made it such that the pure heighs were too long for stems on extremal staves and too short on interior staves.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M lily/stem.cc View 2 chunks +9 lines, -4 lines 2 comments Download

Messages

Total messages: 2
Keith
LGTM of course http://codereview.appspot.com/6543046/diff/1/lily/stem.cc File lily/stem.cc (right): http://codereview.appspot.com/6543046/diff/1/lily/stem.cc#newcode342 lily/stem.cc:342: // find the offset of various ...
11 years, 7 months ago (2012-09-22 05:56:19 UTC) #1
MikeSol
11 years, 7 months ago (2012-09-22 08:36:52 UTC) #2
I'm gonna hold off on posting to this one as it evolves constantly with my work
on issue 2801, which is revealing several issues in cross-staff stem
calculations.  Irrespective of how issue 2801 pans out, I'll take all the
relevant code from stem.cc and either push it as a separate commit or include it
in this Rietveld if my patch for 2801 isn't LGTM'd.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b