Issue 6536059: code review 6536059: race: sync/atomic changes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6536059: code review 6536059: race: sync/atomic changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by dvyukov

Modified:
11 years, 6 months ago

Reviewers:

CC:
rsc, remyoudompheng, gobot, golang-dev

Visibility:
Public.

Description

race: sync/atomic changes This is a part of a bigger change that adds data race detection feature: http://codereview.appspot.com/6456044

Patch Set 1 #

Patch Set 2 : diff -r 28e350401401 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r ee8276dbea49 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r ee8276dbea49 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 998714a0082d https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r 998714a0082d https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 7 : diff -r d4627113a3e9 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 8 : diff -r b1a9967aa474 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+201 lines, -0 lines)			Patch
M	src/pkg/sync/atomic/asm_386.s	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/sync/atomic/asm_amd64.s	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/sync/atomic/asm_arm.s	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/sync/atomic/asm_linux_arm.s	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/sync/atomic/doc.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	src/pkg/sync/atomic/race.go	View	1 2 3 4 5 6 7	1 chunk	+191 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

11 years, 7 months ago (2012-09-19 21:34:26 UTC) #1

dvyukov

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 7 months ago (2012-09-19 21:42:32 UTC) #2

dvyukov

It will break the build w/o runtime changes. On Wed, Sep 26, 2012 at 12:26 ...

11 years, 7 months ago (2012-09-26 19:59:27 UTC) #6

dvyukov

11 years, 6 months ago (2012-10-07 18:07:36 UTC) #7

*** Submitted as http://code.google.com/p/go/source/detail?r=a1bbd399fc9b ***

race: sync/atomic changes
This is a part of a bigger change that adds data race detection feature:
http://codereview.appspot.com/6456044

R=rsc, remyoudompheng
CC=gobot, golang-dev
http://codereview.appspot.com/6536059

Expand All Messages | Collapse All Messages