Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(926)

Issue 6535050: code review 6535050: race: runtime changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by dvyukov
Modified:
11 years, 5 months ago
Reviewers:
minux1, 0xe2.0x9a.0x9b
CC:
rsc, gobot, golang-dev
Visibility:
Public.

Description

race: runtime changes This is a part of a bigger change that adds data race detection feature: http://codereview.appspot.com/6456044

Patch Set 1 #

Patch Set 2 : diff -r fcd0142e77a0 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 28e350401401 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 28e350401401 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 28e350401401 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r ee8276dbea49 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 7 : diff -r d4627113a3e9 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 8 : diff -r dfb1b5655e21 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 9 : diff -r dfb1b5655e21 https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 10

Patch Set 10 : diff -r 7b037816cd5c https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 11 : diff -r 7b037816cd5c https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 12 : diff -r 7b037816cd5c https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 13 : diff -r 7b037816cd5c https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 14 : diff -r 05b050bdd4a0 https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+714 lines, -12 lines) Patch
M src/pkg/runtime/cgocall.c View 1 2 3 4 5 6 7 8 9 10 11 12 6 chunks +24 lines, -0 lines 0 comments Download
M src/pkg/runtime/chan.c View 1 2 3 4 5 6 7 8 9 10 20 chunks +49 lines, -4 lines 0 comments Download
M src/pkg/runtime/hashmap.c View 1 2 3 4 5 6 10 chunks +24 lines, -1 line 0 comments Download
M src/pkg/runtime/malloc.goc View 1 2 3 4 5 6 7 4 chunks +17 lines, -2 lines 1 comment Download
M src/pkg/runtime/mgc0.c View 1 2 3 4 5 6 2 chunks +4 lines, -0 lines 0 comments Download
M src/pkg/runtime/proc.c View 1 7 chunks +14 lines, -2 lines 0 comments Download
A src/pkg/runtime/race.h View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A src/pkg/runtime/race.c View 1 2 3 4 5 6 7 8 1 chunk +255 lines, -0 lines 0 comments Download
A src/pkg/runtime/race.go View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
A src/pkg/runtime/race/race.go View 1 2 3 4 5 1 chunk +105 lines, -0 lines 0 comments Download
A src/pkg/runtime/race/race_darwin_amd64.syso View 1 2 3 4 5 6 7 8 9 10 11 12 13 Binary file 0 comments Download
A src/pkg/runtime/race/race_linux_amd64.syso View 1 2 3 4 5 6 7 8 9 10 11 12 13 Binary file 0 comments Download
A src/pkg/runtime/race0.c View 1 2 3 4 5 6 7 8 9 10 1 chunk +103 lines, -0 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 2 3 4 5 6 7 8 9 3 chunks +4 lines, -1 line 0 comments Download
M src/pkg/runtime/slice.c View 1 2 3 4 5 6 7 8 9 9 chunks +54 lines, -2 lines 0 comments Download
M src/pkg/runtime/time.goc View 1 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
11 years, 6 months ago (2012-09-19 04:57:55 UTC) #1
gobot
R=rsc (assigned by dsymonds)
11 years, 6 months ago (2012-10-02 12:00:16 UTC) #2
rsc
LGTM after fixing below https://codereview.appspot.com/6535050/diff/15017/src/pkg/runtime/cgocall.c File src/pkg/runtime/cgocall.c (right): https://codereview.appspot.com/6535050/diff/15017/src/pkg/runtime/cgocall.c#newcode103 src/pkg/runtime/cgocall.c:103: if(!m->racecall) { Can you do ...
11 years, 5 months ago (2012-10-05 20:35:40 UTC) #3
dvyukov
https://codereview.appspot.com/6535050/diff/15017/src/pkg/runtime/cgocall.c File src/pkg/runtime/cgocall.c (right): https://codereview.appspot.com/6535050/diff/15017/src/pkg/runtime/cgocall.c#newcode103 src/pkg/runtime/cgocall.c:103: if(!m->racecall) { On 2012/10/05 20:35:40, rsc wrote: > Can ...
11 years, 5 months ago (2012-10-07 13:16:00 UTC) #4
dvyukov
*** Submitted as http://code.google.com/p/go/source/detail?r=395c8950719a *** race: runtime changes This is a part of a bigger ...
11 years, 5 months ago (2012-10-07 18:06:18 UTC) #5
minux1
Hi dvyukov, how can I build these two .syso files? Do you plan to add ...
11 years, 5 months ago (2012-10-07 18:13:56 UTC) #6
dvyukov
On Sun, Oct 7, 2012 at 10:13 AM, minux <minux.ma@gmail.com> wrote: > Hi dvyukov, > ...
11 years, 5 months ago (2012-10-07 18:21:11 UTC) #7
minux1
On Mon, Oct 8, 2012 at 2:21 AM, Dmitry Vyukov <dvyukov@google.com> wrote: > On Sun, ...
11 years, 5 months ago (2012-10-07 18:32:51 UTC) #8
dvyukov
On Sun, Oct 7, 2012 at 10:32 AM, minux <minux.ma@gmail.com> wrote: > > On Mon, ...
11 years, 5 months ago (2012-10-08 11:57:03 UTC) #9
atom
https://codereview.appspot.com/6535050/diff/32001/src/pkg/runtime/malloc.goc File src/pkg/runtime/malloc.goc (right): https://codereview.appspot.com/6535050/diff/32001/src/pkg/runtime/malloc.goc#newcode696 src/pkg/runtime/malloc.goc:696: m->racepc = runtime·getcallerpc(&typ); Shouldn't this be: if(raceenabled) m->racepc=...
11 years, 5 months ago (2012-10-12 16:03:59 UTC) #10
dvyukov
11 years, 5 months ago (2012-10-12 16:13:42 UTC) #11
On Fri, Oct 12, 2012 at 8:03 PM, <0xE2.0x9A.0x9B@gmail.com> wrote:

>
> https://codereview.appspot.**com/6535050/diff/32001/src/**
>
pkg/runtime/malloc.goc<https://codereview.appspot.com/6535050/diff/32001/src/pkg/runtime/malloc.goc>
> File src/pkg/runtime/malloc.goc (right):
>
> https://codereview.appspot.**com/6535050/diff/32001/src/**
>
pkg/runtime/malloc.goc#**newcode696<https://codereview.appspot.com/6535050/diff/32001/src/pkg/runtime/malloc.goc#newcode696>
> src/pkg/runtime/malloc.goc:**696: m->racepc = runtime·getcallerpc(&typ);
> Shouldn't this be:
>
> if(raceenabled) m->racepc=...
>


Your right. thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b