LGTM after fixing below https://codereview.appspot.com/6535050/diff/15017/src/pkg/runtime/cgocall.c File src/pkg/runtime/cgocall.c (right): https://codereview.appspot.com/6535050/diff/15017/src/pkg/runtime/cgocall.c#newcode103 src/pkg/runtime/cgocall.c:103: if(!m->racecall) { Can you do ...
11 years, 5 months ago
(2012-10-05 20:35:40 UTC)
#3
On Mon, Oct 8, 2012 at 2:21 AM, Dmitry Vyukov <dvyukov@google.com> wrote: > On Sun, ...
11 years, 5 months ago
(2012-10-07 18:32:51 UTC)
#8
On Mon, Oct 8, 2012 at 2:21 AM, Dmitry Vyukov <dvyukov@google.com> wrote:
> On Sun, Oct 7, 2012 at 10:13 AM, minux <minux.ma@gmail.com> wrote:
>
>> how can I build these two .syso files? Do you plan to add docs for
>> that?
>>
> I am not sure where exactly do I add the instructions.
>
Thanks, maybe you could put this text in src/pkg/runtime/race/README.
btw, do you plan to write an article (/doc/articles/) to introduce
ThreadSanitizer
race detector feature of Go? if you do, that will be a great place for this
information
to go.
A side question: Do we accept .syso files in general? For example, it will
make
porting assembly functions to Go much easier (no more rewrites, and just
make
a abi compatible .syso)
On Sun, Oct 7, 2012 at 10:32 AM, minux <minux.ma@gmail.com> wrote: > > On Mon, ...
11 years, 5 months ago
(2012-10-08 11:57:03 UTC)
#9
On Sun, Oct 7, 2012 at 10:32 AM, minux <minux.ma@gmail.com> wrote:
>
> On Mon, Oct 8, 2012 at 2:21 AM, Dmitry Vyukov <dvyukov@google.com> wrote:
>
>> On Sun, Oct 7, 2012 at 10:13 AM, minux <minux.ma@gmail.com> wrote:
>>
>>> how can I build these two .syso files? Do you plan to add docs for
>>> that?
>>>
>> I am not sure where exactly do I add the instructions.
>>
> Thanks, maybe you could put this text in src/pkg/runtime/race/README.
>
> btw, do you plan to write an article (/doc/articles/) to introduce
> ThreadSanitizer
> race detector feature of Go? if you do, that will be a great place for
> this information
> to go.
>
Well, yes, eventually we need the article.
Do we have a technical writer onboard? :)
A side question: Do we accept .syso files in general? For example, it will
> make
> porting assembly functions to Go much easier (no more rewrites, and just
> make
> a abi compatible .syso)
>
I think that assembly is still preferable. The reason why I upload syso is
being that it's a huge piece of C++ living in a remote repo that needs
fresh gcc/clang to build.
Issue 6535050: code review 6535050: race: runtime changes
(Closed)
Created 11 years, 6 months ago by dvyukov
Modified 11 years, 5 months ago
Reviewers: minux1, 0xe2.0x9a.0x9b_gmail.com
Base URL:
Comments: 11