Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(957)

Issue 6532055: Doc: document \time command fully (2807) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by Trevor Daniels
Modified:
11 years, 7 months ago
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Doc: document \time command fully (2807) - explain optional beatStructure argument of \time and give an example - expand description of \overrideTimeSignatureSettings - add two entries to see alsos - add cross-references - fix incorrect file reference

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -7 lines) Patch
M Documentation/notation/rhythms.itely View 6 chunks +45 lines, -7 lines 1 comment Download

Messages

Total messages: 8
Graham Percival
LGTM http://codereview.appspot.com/6532055/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/6532055/diff/1/Documentation/notation/rhythms.itely#newcode1067 Documentation/notation/rhythms.itely:1067: \time #'(2 2 3) 7/8 woah, cool! When ...
11 years, 7 months ago (2012-09-22 01:30:50 UTC) #1
dak
On 2012/09/22 01:30:50, Graham Percival wrote: > LGTM > > http://codereview.appspot.com/6532055/diff/1/Documentation/notation/rhythms.itely > File Documentation/notation/rhythms.itely (right): ...
11 years, 7 months ago (2012-09-22 04:37:42 UTC) #2
dak
On 2012/09/22 04:37:42, dak wrote: > On 2012/09/22 01:30:50, Graham Percival wrote: > > LGTM ...
11 years, 7 months ago (2012-09-22 07:32:20 UTC) #3
pkx166h
Looks OK to me
11 years, 7 months ago (2012-09-22 08:25:28 UTC) #4
Graham Percival
On Sat, Sep 22, 2012 at 07:32:20AM +0000, dak@gnu.org wrote: > Nobody can be bothered ...
11 years, 7 months ago (2012-09-23 02:27:52 UTC) #5
Trevor Daniels
Pushed to staging as f8710cbaf9563515cf383c658a534b5c902897a1 Closing
11 years, 7 months ago (2012-09-24 10:58:29 UTC) #6
janek
On Saturday, September 22, 2012, David wrote: > Nobody can be bothered enough to even ...
11 years, 7 months ago (2012-09-26 14:40:18 UTC) #7
janek
11 years, 7 months ago (2012-09-26 14:40:19 UTC) #8
On Saturday, September 22, 2012, David wrote:
>
> 2.15.19:
>
> commit a512132fed73a94068b91fb0bab473**319e477b6e
> Author: David Kastrup <dak@gnu.org>
> Date:   Wed Nov 9 11:37:39 2011 +0100
>
>     Fold set-time-signature into \time
>
> It may be instructional to look at the diff itself.  That's the kind of
> thing possible just using music functions now, without the need of
> messing with the parser.  I am not entirely sure that it would not have
> been more prudent to instead fold \compoundTime into \time, but as long
> as nobody bothers reviewing such changes, I need to make them without
> feedback
>

David, i'm sorry that this had happened.  Indeed this was a change both
easy and short to review, and i wish i had reviewed it.  I have missed many
things during my absence in last year Autumn.
I want to assure you that i believe this is a needed and useful change, and
i will be happy to see more similar changes in the future.

best,
Janek
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b