Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1448)

Issue 6528043: code review 6528043: runtime: hide the semaphore table from garbage collector (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by atom
Modified:
11 years, 6 months ago
Reviewers:
CC:
rsc, dvyukov, dfc, golang-dev
Visibility:
Public.

Description

runtime: hide the semaphore table from garbage collector

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/pkg/runtime/sema.goc View 2 chunks +5 lines, -3 lines 2 comments Download

Messages

Total messages: 6
atom
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 6 months ago (2012-09-18 05:37:10 UTC) #1
dvyukov
LGTM
11 years, 6 months ago (2012-09-18 16:34:30 UTC) #2
dfc
http://codereview.appspot.com/6528043/diff/1/src/pkg/runtime/sema.goc File src/pkg/runtime/sema.goc (right): http://codereview.appspot.com/6528043/diff/1/src/pkg/runtime/sema.goc#newcode51 src/pkg/runtime/sema.goc:51: #pragma dataflag 16 /* mark semtable as 'no pointers', ...
11 years, 6 months ago (2012-09-18 16:39:08 UTC) #3
atom
https://codereview.appspot.com/6528043/diff/1/src/pkg/runtime/sema.goc File src/pkg/runtime/sema.goc (right): https://codereview.appspot.com/6528043/diff/1/src/pkg/runtime/sema.goc#newcode51 src/pkg/runtime/sema.goc:51: #pragma dataflag 16 /* mark semtable as 'no pointers', ...
11 years, 6 months ago (2012-09-18 18:01:42 UTC) #4
rsc
LGTM
11 years, 6 months ago (2012-09-18 18:27:50 UTC) #5
rsc
11 years, 6 months ago (2012-09-18 18:30:08 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=74b7f46062d9 ***

runtime: hide the semaphore table from garbage collector

R=rsc, dvyukov, dave
CC=golang-dev
http://codereview.appspot.com/6528043

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b