Issue 6524047: code review 6524047: go/doc: strip example output comment from synthesized m...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6524047: code review 6524047: go/doc: strip example output comment from synthesized m... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by adg

Modified:
11 years, 6 months ago

Reviewers:

CC:
gri, gobot, golang-dev

Visibility:
Public.

Description

go/doc: strip example output comment from synthesized main function

Patch Set 2 : diff -r 838111caecdd https://go.googlecode.com/hg #

Total comments: 2

Patch Set 3 : diff -r be1af56822d4 https://go.googlecode.com/hg #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -12 lines)			Patch
	M	src/pkg/go/doc/example.go	View	1 2	5 chunks	+26 lines, -12 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

11 years, 7 months ago (2012-09-19 00:36:58 UTC) #1

gri

LGTM apologies for the delay https://codereview.appspot.com/6524047/diff/3001/src/pkg/go/doc/example.go File src/pkg/go/doc/example.go (right): https://codereview.appspot.com/6524047/diff/3001/src/pkg/go/doc/example.go#newcode97 src/pkg/go/doc/example.go:97: return strings.TrimSpace(last.Text()[loc[1]:]) Why is ...

11 years, 6 months ago (2012-09-28 18:03:37 UTC) #4

adg

11 years, 6 months ago (2012-10-01 22:35:49 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=b09f4985724f ***

go/doc: strip example output comment from synthesized main function

R=gri
CC=gobot, golang-dev
http://codereview.appspot.com/6524047

http://codereview.appspot.com/6524047/diff/3001/src/pkg/go/doc/example.go
File src/pkg/go/doc/example.go (right):

http://codereview.appspot.com/6524047/diff/3001/src/pkg/go/doc/example.go#new...
src/pkg/go/doc/example.go:97: return strings.TrimSpace(last.Text()[loc[1]:])
On 2012/09/28 18:03:38, gri wrote:
> Why is text here not ok? it there's a reason, it needs a comment.

This was an accident of some experimentation I did.

Expand All Messages | Collapse All Messages