code review 6506120: text/template: fix typo of errorf as error in comment.

text/template: fix typo of errorf as error in comment.

[jshholland, 2012-09-16 01:34:46]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[jshholland, 2012-09-16 03:21:41]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[gobot, 2012-09-20 06:48:46]

R=r (assigned by dsymonds)

[r, 2012-09-20 19:29:58]

Thanks for the careful scan but let's tweak a little.

http://codereview.appspot.com/6506120/diff/5001/src/pkg/text/template/parse/l...
File src/pkg/text/template/parse/lex.go (right):

http://codereview.appspot.com/6506120/diff/5001/src/pkg/text/template/parse/l...
src/pkg/text/template/parse/lex.go:18: val string   // the value of this item.
Revert these three lines. They were properly punctuated; now they're not.

http://codereview.appspot.com/6506120/diff/5001/src/pkg/text/template/parse/l...
src/pkg/text/template/parse/lex.go:69: itemWith     // with keyword.
these are not sentences and do not need periods. revert.

http://codereview.appspot.com/6506120/diff/5001/src/pkg/text/template/parse/l...
src/pkg/text/template/parse/lex.go:101: parenDepth int       // nesting depth of
( ) exprs.
here you've found an inconsistency. i'd prefer going the other way, deleting the
periods.

[jshholland, 2012-09-21 10:29:33]

Hello r@golang.org (cc: gobot@golang.org, golang-dev@googlegroups.com),

Please take another look.

[jshholland, 2012-09-21 10:29:52]

PTAL. To confirm, the rule is caps and full stop iff the comment is a full
sentence?

https://codereview.appspot.com/6506120/diff/5001/src/pkg/text/template/parse/...
File src/pkg/text/template/parse/lex.go (right):

https://codereview.appspot.com/6506120/diff/5001/src/pkg/text/template/parse/...
src/pkg/text/template/parse/lex.go:18: val string   // the value of this item.
On 2012/09/20 19:29:58, r wrote:
> Revert these three lines. They were properly punctuated; now they're not.

Done.

https://codereview.appspot.com/6506120/diff/5001/src/pkg/text/template/parse/...
src/pkg/text/template/parse/lex.go:69: itemWith     // with keyword.
On 2012/09/20 19:29:58, r wrote:
> these are not sentences and do not need periods. revert.

Done.

https://codereview.appspot.com/6506120/diff/5001/src/pkg/text/template/parse/...
src/pkg/text/template/parse/lex.go:101: parenDepth int       // nesting depth of
( ) exprs.
On 2012/09/20 19:29:58, r wrote:
> here you've found an inconsistency. i'd prefer going the other way, deleting
the
> periods.

Done.

[r, 2012-09-24 03:37:23]

this is good but you'll need to sync and upload.

[r, 2012-09-24 03:45:20]

You'll also need to fill in the CLA as described at
http://golang.org/doc/contribute.html#copyright

-rob

[jshholland, 2012-09-24 15:07:18]

I have done "hg sync", followed by "hg change 6506120". I believe this is
correct. I think I already did the CLA when I initially proposed the change.

Thanks,
Josh

On 24 September 2012 04:45, Rob Pike <r@golang.org> wrote:

> You'll also need to fill in the CLA as described at
> http://golang.org/doc/contribute.html#copyright
>
> -rob
>

[jshholland, 2012-09-24 16:46:05]

Hello r@golang.org (cc: gobot@golang.org, golang-dev@googlegroups.com),

Please take another look.

[jshholland, 2012-09-24 16:46:43]

On 2012/09/24 16:46:05, jshholland wrote:
> Hello mailto:r@golang.org (cc: mailto:gobot@golang.org,
mailto:golang-dev@googlegroups.com),
> 
> Please take another look.

I accidentally deleted a line; this puts it back (is there a way to specify text
that isn't just "Please take another look" from hg mail?)

Thanks,
Josh

[minux1, 2012-09-24 16:50:37]

On Tuesday, September 25, 2012, wrote:
>
> I accidentally deleted a line; this puts it back (is there a way to
> specify text that isn't just "Please take another look" from hg mail?)
>
You can just 'hg upload NNNNN', and then send the message from
the web interface of Rietveld.

[r, 2012-09-27 05:46:50]

LGTM

[r, 2012-09-27 05:48:00]

*** Submitted as http://code.google.com/p/go/source/detail?r=820619c4c27b ***

text/template: fix typo of errorf as error in comment.

R=r, minux.ma
CC=gobot, golang-dev
http://codereview.appspot.com/6506120

Committer: Rob Pike <r@golang.org>