Issue 6506111: Address warnings from clang build bot

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6506111: Address warnings from clang build bot (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by robertphillips

Modified:
12 years ago

Reviewers:
rileya, bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Address warnings from clang build bot

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -29 lines)			Patch
M	samplecode/SampleLayers.cpp	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	src/animator/SkDisplayEvent.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/animator/SkDisplayPost.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/animator/SkDrawExtraPathEffect.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/animator/SkDrawGradient.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/animator/SkDrawGroup.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/animator/SkDrawMatrix.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/animator/SkDrawPath.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/animator/SkDrawPath.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkPictureRecord.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/core/SkPictureStateTree.h	View	1 chunk	+7 lines, -5 lines	0 comments	Download
M	src/core/SkPictureStateTree.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkRTree.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/RTreeTest.cpp	View	4 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 4

rileya

I don't know enough about animator to comment on the other stuff but the picture/rtree ...

12 years ago (2012-09-13 12:38:59 UTC) #2

bsalomon

On 2012/09/13 12:38:59, rileya wrote: > I don't know enough about animator to comment on ...

12 years ago (2012-09-13 13:12:44 UTC) #3

committed as r5518