Issue 6503088: Fix complaints from jsLint.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6503088: Fix complaints from jsLint. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by Shaopeng

Modified:
13 years, 3 months ago

Reviewers:
davinci_google, lararennie

Base URL:
http://libphonenumber.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Fix complaints from jsLint. Committed: http://code.google.com/p/libphonenumber/source/detail?r=523

Patch Set 1 #

Total comments: 1

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	javascript/i18n/phonenumbers/asyoutypeformatter.js	View		2 chunks	+4 lines, -5 lines	0 comments	Download
	M	javascript/i18n/phonenumbers/phonenumberutil.js	View		1 chunk	+4 lines, -2 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

davinci_google

On 2012/09/07 14:12:58, Shaopeng wrote: > This CL fixes complaints from JS Lint. LGTM.

13 years, 3 months ago (2012-09-07 14:17:49 UTC) #2

lararennie

When I ran jslint, I got these errors about missing documentation but also about 50 ...

13 years, 3 months ago (2012-09-10 07:20:30 UTC) #3

Shaopeng

13 years, 3 months ago (2012-09-11 05:36:08 UTC) #4

The ones I fixed were the only complaints flagged by the internal lint when
I send out the internal code review.

2012/9/10 <lararennie@google.com>

> When I ran jslint, I got these errors about missing documentation but
> also about 50 more, why did you not fix all the other locations as well?
> I decided we didn't have to have comments for every param/return value,
> since we hadn't previously...
>
>
> https://codereview.appspot.**com/6503088/diff/1/javascript/**
>
i18n/phonenumbers/**phonenumberutil.js<https://codereview.appspot.com/6503088/diff/1/javascript/i18n/phonenumbers/phonenumberutil.js>
> File javascript/i18n/phonenumbers/**phonenumberutil.js (right):
>
> https://codereview.appspot.**com/6503088/diff/1/javascript/**
>
i18n/phonenumbers/**phonenumberutil.js#newcode1291<https://codereview.appspot.com/6503088/diff/1/javascript/i18n/phonenumbers/phonenumberutil.js#newcode1291>
> javascript/i18n/phonenumbers/**phonenumberutil.js:1291: * @param {string}
>
> nationalPrefixFormattingRule The formatting rule for the
> Shouldn't start with a capital for consistency
>
>
https://codereview.appspot.**com/6503088/<https://codereview.appspot.com/6503...
>

Expand All Messages | Collapse All Messages