Issue 6503064: SkTextBox: Add line break after CRLF or LF

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6503064: SkTextBox: Add line break after CRLF or LF (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by Jare

Modified:
12 years, 9 months ago

Reviewers:
bungeman, skia-review

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

This patch support both "\r\n" and "\n" automatically. It provides a simplest support for printing multiline...

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -7 lines)			Patch
		include/views/SkTextBox.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
		src/views/SkTextBox.cpp	View		4 chunks	+57 lines, -7 lines	0 comments	Download

Total messages: 6

Jare

This patch support both "\r\n" and "\n" automatically. It provides a simplest support for printing ...

12 years, 9 months ago (2012-09-04 06:06:27 UTC) #3

Jare

This patch support both "\r\n" and "\n" automatically. It provides a simplest support for printing ...

12 years, 9 months ago (2012-09-04 13:26:39 UTC) #4

Jare

This patch support both "\r\n" and "\n" automatically. It provides a simplest support for printing ...

12 years, 9 months ago (2012-09-04 16:31:40 UTC) #5

bungeman

12 years, 9 months ago (2012-09-05 16:05:22 UTC) #6

I started looking at this and would prefer this worked in a manner closer to how
it used to work. See https://codereview.appspot.com/6500078/ .