Issue 6503053: Shut up some Mac (xcode 3) warnings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6503053: Shut up some Mac (xcode 3) warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by bsalomon

Modified:
11 years, 9 months ago

Reviewers:
robertphillips, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Patch Set 3 : really fix the ~0 for stencil settings #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -20 lines)			Patch
M	experimental/Debugger/DebuggerContentView.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	gm/gradtext.cpp	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/animator/SkScriptTokenizer.cpp	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/core/SkBitmapProcState_shaderproc.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/core/SkPixelRef.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/effects/gradients/SkTwoPointConicalGradient.cpp	View	1	2 chunks	+1 line, -3 lines	0 comments	Download
M	src/gpu/GrClipMaskManager.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGLProgram.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/utils/SkDeferredCanvas.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/ClipStackTest.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/DeferredCanvasTest.cpp	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download
M	tools/skdiff_main.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

robertphillips

LGTM modulo 1 question http://codereview.appspot.com/6503053/diff/7/experimental/Debugger/DebuggerContentView.cpp File experimental/Debugger/DebuggerContentView.cpp (right): http://codereview.appspot.com/6503053/diff/7/experimental/Debugger/DebuggerContentView.cpp#newcode260 experimental/Debugger/DebuggerContentView.cpp:260: I've seen this around a ...

11 years, 10 months ago (2012-08-30 19:42:51 UTC) #2

bsalomon

11 years, 10 months ago (2012-08-30 19:50:17 UTC) #3

http://codereview.appspot.com/6503053/diff/7/experimental/Debugger/DebuggerCo...
File experimental/Debugger/DebuggerContentView.cpp (right):

http://codereview.appspot.com/6503053/diff/7/experimental/Debugger/DebuggerCo...
experimental/Debugger/DebuggerContentView.cpp:260: 
On 2012/08/30 19:42:51, robertphillips wrote:
> I've seen this around a bit and was thinking about removing them - what
warning
> is generated w/o them?

It's that no declaration was seen before a definition. It only appears if the
function is not static (or namespaced). It can be annoying but on the flip side
it catches places where people forgot to make their functions local. A few of
these are fixed in other files in this change and were caught by the warning.

Expand All Messages | Collapse All Messages