Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1165)

Issue 6501122: Turn down repeat count on ref counting and memory pool benches (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 12 months ago by TomH
Modified:
11 years, 12 months ago
Reviewers:
EricB, bsalomon, benchen, reed1
CC:
senorblanco, epoger
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

It seems to me that there are many benches we run for several tens of ms when running them for 5-10ms would give us plenty of information. These are the easiest two targets, and a spur to discussion. I'd argue that on our target desktop platforms no 8888 bench should be taking longer than 20ms. (This runs into a problem with morph, where even a single operation with a 10px kernel takes > 30ms - but do we really need to be testing blends that large?)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M bench/GrMemoryPoolBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/RefCntBench.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
TomH
11 years, 12 months ago (2012-09-12 11:30:24 UTC) #1
bsalomon
On 2012/09/12 11:30:24, TomH wrote: LGTM
11 years, 12 months ago (2012-09-12 12:44:20 UTC) #2
bsalomon
On 2012/09/12 12:44:20, bsalomon wrote: > On 2012/09/12 11:30:24, TomH wrote: > LGTM And agreed ...
11 years, 12 months ago (2012-09-12 12:44:44 UTC) #3
TomH
11 years, 12 months ago (2012-09-13 15:42:57 UTC) #4
Committed in r5524. And committed to further reduction.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b