Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3373)

Issue 6500115: Let SkBenchmark subclasses specify that they do no rendering (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by TomH
Modified:
12 years, 3 months ago
CC:
bungeman
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

By default SkBenchmark sets fIsRendering to true. Subclasses can set it to false in their constructor. If !fIsRendering, the benchmark only executes for one config, whether we specify one or all configs (8888, 565, GPU, NULLGPU). This change gives a 15-20% speedup on bench cycle time. I suspect there are more benchmark suites that could be flagged as non-rendering for a bit more speedup. As long as we're driving the bench graphs with a consistent set of configs, we'll see these always show up on the same set (8888).

Patch Set 1 #

Total comments: 1

Patch Set 2 : Marked isfinite and floor benches non-rendering #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M bench/GrMemoryPoolBench.cpp View 3 chunks +3 lines, -0 lines 0 comments Download
M bench/InterpBench.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M bench/MathBench.cpp View 1 3 chunks +4 lines, -0 lines 0 comments Download
M bench/MatrixBench.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M bench/MemoryBench.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M bench/RTreeBench.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M bench/RefCntBench.cpp View 6 chunks +6 lines, -0 lines 0 comments Download
M bench/RegionBench.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M bench/SkBenchmark.h View 2 chunks +9 lines, -0 lines 0 comments Download
M bench/SkBenchmark.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M bench/benchmain.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7
TomH
Why yes, New and Improved Skia is now 20% faster according to independent scientific tests. ...
12 years, 3 months ago (2012-09-12 09:34:34 UTC) #1
TomH
...adding still more reviewers - hopefully this now hits *everybody* who has *ever* paid attention ...
12 years, 3 months ago (2012-09-13 15:01:25 UTC) #2
reed1
lgtm
12 years, 3 months ago (2012-09-13 15:03:06 UTC) #3
bsalomon
On 2012/09/13 15:01:25, TomH wrote: > ...adding still more reviewers - hopefully this now hits ...
12 years, 3 months ago (2012-09-13 15:03:56 UTC) #4
TomH
On 2012/09/13 15:03:56, bsalomon wrote: > Should we have a special config name associated with ...
12 years, 3 months ago (2012-09-13 15:07:45 UTC) #5
epoger
LGTM On 2012/09/13 15:07:45, TomH wrote: > On 2012/09/13 15:03:56, bsalomon wrote: > > Should ...
12 years, 3 months ago (2012-09-13 15:44:00 UTC) #6
TomH
12 years, 3 months ago (2012-09-13 15:51:14 UTC) #7
On 2012/09/13 15:44:00, epoger wrote:
> I think the large number of reviewers triggered
> http://en.wikipedia.org/wiki/Diffusion_of_responsibility

Yep.

Closed with r5525.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b