Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(191)

Issue 6500087: code review 6500087: exp/locale/collate: added indices to builder for reusin... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by mpvl
Modified:
11 years, 6 months ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

exp/locale/collate: added indices to builder for reusing blocks between locales. Refactored build + buildTrie into build + buildOrdering. Note that since the tailoring code is not checked in yet, all tailorings are identical to root. The table therefore should not and does not grow at this point.

Patch Set 1 #

Patch Set 2 : diff -r b8637622df90 https://go.googlecode.com/hg #

Patch Set 3 : diff -r b8637622df90 https://go.googlecode.com/hg #

Total comments: 2

Patch Set 4 : diff -r d87f966bd36e https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -59 lines) Patch
M src/pkg/exp/locale/collate/build/builder.go View 1 2 3 8 chunks +73 lines, -55 lines 0 comments Download
M src/pkg/exp/locale/collate/build/builder_test.go View 1 3 chunks +4 lines, -4 lines 0 comments Download
M src/pkg/exp/locale/collate/build/order.go View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
mpvl
Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg
11 years, 6 months ago (2012-09-06 12:11:34 UTC) #1
r
LGTM http://codereview.appspot.com/6500087/diff/5001/src/pkg/exp/locale/collate/build/builder.go File src/pkg/exp/locale/collate/build/builder.go (right): http://codereview.appspot.com/6500087/diff/5001/src/pkg/exp/locale/collate/build/builder.go#newcode49 src/pkg/exp/locale/collate/build/builder.go:49: ctElemMap map[string]int don't put the type in the ...
11 years, 6 months ago (2012-09-07 18:01:09 UTC) #2
mpvl
http://codereview.appspot.com/6500087/diff/5001/src/pkg/exp/locale/collate/build/builder.go File src/pkg/exp/locale/collate/build/builder.go (right): http://codereview.appspot.com/6500087/diff/5001/src/pkg/exp/locale/collate/build/builder.go#newcode49 src/pkg/exp/locale/collate/build/builder.go:49: ctElemMap map[string]int On 2012/09/07 18:01:09, r wrote: > don't ...
11 years, 6 months ago (2012-09-08 01:45:35 UTC) #3
mpvl
11 years, 6 months ago (2012-09-08 01:47:13 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=0a0666f2fe86 ***

exp/locale/collate: added indices to builder for reusing blocks between locales.
Refactored build + buildTrie into build + buildOrdering.
Note that since the tailoring code is not checked in yet, all tailorings are
identical
to root.  The table therefore should not and does not grow at this point.

R=r
CC=golang-dev
http://codereview.appspot.com/6500087
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b