Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(68)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
6499123
: Fixed memory leak in deferred_canvas_record bench (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by
robertphillips
Modified:
11 years, 11 months ago
Reviewers:
EricB
,
TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.
More Reviews
Description
Before this fix a repeat=20 run of this bench would "leak" 457 SkRefCnt-derived objects. With this fix only 1 is "leaked".
Patch Set 1
#
Created:
11 years, 11 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+6 lines, -2 lines
)
Patch
M
bench/DeferredCanvasBench.cpp
View
1 chunk
+6 lines, -2 lines
0 comments
Download
Messages
Total messages: 3
Expand All Messages
|
Collapse All Messages
robertphillips
11 years, 11 months ago (2012-09-17 11:21:19 UTC)
#1
Sign in
to reply to this message.
EricB
LGTM
11 years, 11 months ago (2012-09-17 11:51:38 UTC)
#2
LGTM
Sign in
to reply to this message.
robertphillips
committed as r5564
11 years, 11 months ago (2012-09-17 11:53:07 UTC)
#3
committed as r5564
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 6499123: Fixed memory leak in deferred_canvas_record bench (Closed)
Created 11 years, 11 months ago by robertphillips
Modified 11 years, 11 months ago
Reviewers: TomH, EricB
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b