Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1752)

Issue 6499118: code review 6499118: runtime: fix mmap comments (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by minux1
Modified:
11 years, 6 months ago
Reviewers:
CC:
r, dfc, rsc, golang-dev
Visibility:
Public.

Description

runtime: fix mmap comments We only pass lower 32 bits of file offset to asm routine.

Patch Set 1 #

Patch Set 2 : diff -r e990cf183236 https://code.google.com/p/go #

Patch Set 3 : diff -r e990cf183236 https://code.google.com/p/go #

Patch Set 4 : diff -r b0c749cc5654 https://code.google.com/p/go #

Patch Set 5 : diff -r b0c749cc5654 https://code.google.com/p/go #

Patch Set 6 : diff -r 273e4b33db08 https://code.google.com/p/go/ #

Patch Set 7 : diff -r 273e4b33db08 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M src/pkg/runtime/runtime.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/runtime/sys_freebsd_386.s View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/sys_netbsd_386.s View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/sys_openbsd_386.s View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 6 months ago (2012-09-16 13:29:37 UTC) #1
r
LGTM
11 years, 6 months ago (2012-09-16 13:37:45 UTC) #2
dfc
What about mem_linux.c:map_fixed, offset is a uint32 there, and passed to runtime.mmap. I'm also concerned ...
11 years, 6 months ago (2012-09-16 15:14:54 UTC) #3
rsc
Does it matter? I think we always pass 0 for that argument, and it seems ...
11 years, 6 months ago (2012-09-16 16:09:37 UTC) #4
minux1
On Mon, Sep 17, 2012 at 12:09 AM, Russ Cox <rsc@golang.org> wrote: > Does it ...
11 years, 6 months ago (2012-09-16 16:17:25 UTC) #5
minux1
On Mon, Sep 17, 2012 at 12:17 AM, minux <minux.ma@gmail.com> wrote: > > i haven't ...
11 years, 6 months ago (2012-09-16 16:24:15 UTC) #6
minux1
On Monday, September 17, 2012, minux wrote: > > On Mon, Sep 17, 2012 at ...
11 years, 6 months ago (2012-09-16 19:39:35 UTC) #7
rsc
Sure, comments to avoid future confusion are always welcome.
11 years, 6 months ago (2012-09-17 18:35:07 UTC) #8
minux1
On 2012/09/17 18:35:07, rsc wrote: > Sure, comments to avoid future confusion are always welcome. ...
11 years, 6 months ago (2012-09-19 11:44:13 UTC) #9
rsc
LGTM
11 years, 6 months ago (2012-09-20 18:50:58 UTC) #10
minux1
11 years, 6 months ago (2012-09-21 05:50:17 UTC) #11
*** Submitted as http://code.google.com/p/go/source/detail?r=90c9121e26c3 ***

runtime: fix mmap comments
We only pass lower 32 bits of file offset to asm routine.

R=r, dave, rsc
CC=golang-dev
http://codereview.appspot.com/6499118
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b