Issue 6499105: Issues warning for empty note column extents

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6499105: Issues warning for empty note column extents (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by MikeSol

Modified:
12 years, 4 months ago

Reviewers:
Keith

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

Issues warning for empty note column extents Removes check for duration-log from Stem::is_valid_stem.

Patch Set 1 #

Total comments: 2

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -8 lines)			Patch
	M	lily/slur-scoring.cc	View		1 chunk	+9 lines, -5 lines	0 comments	Download
	M	lily/stem.cc	View		1 chunk	+0 lines, -3 lines	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Keith

LGTM http://codereview.appspot.com/6499105/diff/1/lily/stem.cc File lily/stem.cc (left): http://codereview.appspot.com/6499105/diff/1/lily/stem.cc#oldcode814 lily/stem.cc:814: if (lh && robust_scm2int (lh->get_property ("duration-log"), 0) < ...

12 years, 6 months ago (2012-09-14 06:38:10 UTC) #1

Keith

12 years, 6 months ago (2012-09-14 07:45:08 UTC) #2

http://codereview.appspot.com/6499105/diff/1/lily/stem.cc
File lily/stem.cc (left):

http://codereview.appspot.com/6499105/diff/1/lily/stem.cc#oldcode814
lily/stem.cc:814: if (lh && robust_scm2int (lh->get_property ("duration-log"),
0) < 1)
On 2012/09/14 06:38:10, Keith wrote:
> Removing this looks extremely sensible.
'stem-stemlet-whole.ly'
Oh well.

Checking the duration-log of the Stem, as opposed to note-head, in is_visible(),
still seems to make more sense to me.

Expand All Messages | Collapse All Messages