Issue 6499077: Enforce calling of inherited onRelease & onAbandon mthds in GrResource-derived classes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6499077: Enforce calling of inherited onRelease & onAbandon mthds in GrResource-derived classes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by robertphillips

Modified:
11 years, 10 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 2

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -8 lines)			Patch
M	include/gpu/GrResource.h	View	1 chunk	+2 lines, -2 lines	2 comments	Download
M	src/gpu/GrRenderTarget.cpp	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/gpu/GrTexture.cpp	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLIndexBuffer.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLIndexBuffer.cpp	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLPath.cpp	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLStencilBuffer.cpp	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLTexture.cpp	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLVertexBuffer.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLVertexBuffer.cpp	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

LGTM https://codereview.appspot.com/6499077/diff/1/include/gpu/GrResource.h File include/gpu/GrResource.h (right): https://codereview.appspot.com/6499077/diff/1/include/gpu/GrResource.h#newcode78 include/gpu/GrResource.h:78: virtual void onRelease() {}; I wish C++ gave ...

11 years, 10 months ago (2012-09-05 18:26:17 UTC) #2

robertphillips

11 years, 10 months ago (2012-09-05 18:38:12 UTC) #3

committed as r5405

https://codereview.appspot.com/6499077/diff/1/include/gpu/GrResource.h
File include/gpu/GrResource.h (right):

https://codereview.appspot.com/6499077/diff/1/include/gpu/GrResource.h#newcode78
include/gpu/GrResource.h:78: virtual void onRelease() {};
On 2012/09/05 18:26:18, bsalomon wrote:
> I wish C++ gave us some way to enforce that it is called. Maybe we should at
> least document here that any overrides should call their parent class's
> function. 

Done.

Expand All Messages | Collapse All Messages