Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(135)

Issue 6499077: Enforce calling of inherited onRelease & onAbandon mthds in GrResource-derived classes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by robertphillips
Modified:
12 years, 2 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Minor code cleanup.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -8 lines) Patch
M include/gpu/GrResource.h View 1 chunk +2 lines, -2 lines 2 comments Download
M src/gpu/GrRenderTarget.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/GrTexture.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLIndexBuffer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLIndexBuffer.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLPath.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLStencilBuffer.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLTexture.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLVertexBuffer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLVertexBuffer.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3
robertphillips
12 years, 2 months ago (2012-09-05 18:11:48 UTC) #1
bsalomon
LGTM https://codereview.appspot.com/6499077/diff/1/include/gpu/GrResource.h File include/gpu/GrResource.h (right): https://codereview.appspot.com/6499077/diff/1/include/gpu/GrResource.h#newcode78 include/gpu/GrResource.h:78: virtual void onRelease() {}; I wish C++ gave ...
12 years, 2 months ago (2012-09-05 18:26:17 UTC) #2
robertphillips
12 years, 2 months ago (2012-09-05 18:38:12 UTC) #3
committed as r5405

https://codereview.appspot.com/6499077/diff/1/include/gpu/GrResource.h
File include/gpu/GrResource.h (right):

https://codereview.appspot.com/6499077/diff/1/include/gpu/GrResource.h#newcode78
include/gpu/GrResource.h:78: virtual void onRelease() {};
On 2012/09/05 18:26:18, bsalomon wrote:
> I wish C++ gave us some way to enforce that it is called. Maybe we should at
> least document here that any overrides should call their parent class's
> function. 

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b