Issue 6498132: Made more benchs non-rendering

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6498132: Made more benchs non-rendering (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by robertphillips

Modified:
13 years ago

Reviewers:
EricB

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

None of these appear to actually render anything

Patch Set 1 #

Total comments: 2

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -2 lines)			Patch
M	bench/ChecksumBench.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	bench/DecodeBench.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	bench/MutexBench.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	bench/PathIterBench.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	bench/ScalarBench.cpp	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	bench/WriterBench.cpp	View	1 chunk	+3 lines, -1 line	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

EricB

LGTM with question. http://codereview.appspot.com/6498132/diff/1/bench/WriterBench.cpp File bench/WriterBench.cpp (right): http://codereview.appspot.com/6498132/diff/1/bench/WriterBench.cpp#newcode16 bench/WriterBench.cpp:16: fIsRendering = false; Is there any ...

13 years, 1 month ago (2012-09-14 19:33:51 UTC) #2

robertphillips

13 years ago (2012-09-17 10:49:51 UTC) #3

committed as r5562

http://codereview.appspot.com/6498132/diff/1/bench/WriterBench.cpp
File bench/WriterBench.cpp (right):

http://codereview.appspot.com/6498132/diff/1/bench/WriterBench.cpp#newcode16
bench/WriterBench.cpp:16: fIsRendering = false;
I actually prefer them but I was just following how this was implemented
elsewhere.

Expand All Messages | Collapse All Messages