Issue 6497147: code review 6497147: cmd/gc: add missing conversion from bool to interface i...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6497147: code review 6497147: cmd/gc: add missing conversion from bool to interface i... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by DMorsing

Modified:
11 years, 7 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/gc: add missing conversion from bool to interface in switches. In switches without an expression, the compiler would not convert the implicit true to an interface, causing codegen errors. Fixes issue 3980.

Patch Set 1 #

Patch Set 2 : diff -r 23b89fb47d66 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 23b89fb47d66 https://code.google.com/p/go/ #

Total comments: 4

Patch Set 4 : diff -r 23b89fb47d66 https://code.google.com/p/go/ #

Patch Set 5 : diff -r d27358d77d44 https://code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -0 lines)			Patch
	M	src/cmd/gc/swt.c	View	1	3 chunks	+7 lines, -0 lines	0 comments	Download
	M	test/switch.go	View	1 2 3	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

DMorsing

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 7 months ago (2012-09-17 18:17:25 UTC) #1

rsc

LGTM Thanks. http://codereview.appspot.com/6497147/diff/4001/src/cmd/gc/swt.c File src/cmd/gc/swt.c (right): http://codereview.appspot.com/6497147/diff/4001/src/cmd/gc/swt.c#newcode464 src/cmd/gc/swt.c:464: snorm: I am not sure what snorm ...

11 years, 7 months ago (2012-09-17 18:51:47 UTC) #2

DMorsing

PTAL http://codereview.appspot.com/6497147/diff/4001/src/cmd/gc/swt.c File src/cmd/gc/swt.c (right): http://codereview.appspot.com/6497147/diff/4001/src/cmd/gc/swt.c#newcode464 src/cmd/gc/swt.c:464: snorm: On 2012/09/17 18:51:48, rsc wrote: > I ...

11 years, 7 months ago (2012-09-17 19:05:47 UTC) #3

DMorsing

11 years, 7 months ago (2012-09-17 19:29:18 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=0e064ff6123c ***

cmd/gc: add missing conversion from bool to interface in switches.

In switches without an expression, the compiler would not convert the implicit
true to an interface, causing codegen errors.

Fixes issue 3980.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6497147

Expand All Messages | Collapse All Messages