Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(844)

Issue 6497057: juju: update unknown config attrs once (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by dave
Modified:
12 years, 10 months ago
Reviewers:
mp+121979, niemeyer
Visibility:
Public.

Description

juju: update unknown config attrs once Additional UnknownAttrs from the local environment will only be applied if they do not already exist in the state. https://code.launchpad.net/~dave-cheney/juju-core/080-conn-update-secrets-only-if-needed/+merge/121979 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : juju: update unknown config attrs once #

Total comments: 1

Patch Set 3 : juju: update unknown config attrs once #

Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -200 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/cmd_test.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/main_test.go View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M environs/cloudinit/cloudinit.go View 1 2 5 chunks +8 lines, -8 lines 0 comments Download
M environs/cloudinit/cloudinit_test.go View 1 2 8 chunks +36 lines, -16 lines 0 comments Download
M environs/config.go View 1 2 2 chunks +19 lines, -0 lines 0 comments Download
M environs/config/config.go View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M environs/dummy/environs.go View 1 2 4 chunks +28 lines, -7 lines 0 comments Download
M environs/ec2/ec2.go View 1 2 4 chunks +11 lines, -24 lines 0 comments Download
M environs/jujutest/test.go View 1 2 5 chunks +14 lines, -19 lines 0 comments Download
M environs/tools.go View 1 2 2 chunks +35 lines, -14 lines 0 comments Download
M environs/tools_test.go View 1 2 8 chunks +152 lines, -101 lines 0 comments Download
M juju/conn.go View 1 chunk +5 lines, -5 lines 0 comments Download
M juju/conn_test.go View 2 chunks +24 lines, -1 line 0 comments Download
M state/machine.go View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8
dave_cheney.net
Please take a look.
12 years, 10 months ago (2012-08-30 03:36:27 UTC) #1
dave_cheney.net
Please take a look.
12 years, 10 months ago (2012-08-31 02:01:41 UTC) #2
dave_cheney.net
On 2012/08/31 02:01:41, dfc wrote: > Please take a look. URGH - prereq fail. WIll ...
12 years, 10 months ago (2012-08-31 02:02:32 UTC) #3
niemeyer
http://codereview.appspot.com/6497057/diff/3001/juju/conn.go File juju/conn.go (right): http://codereview.appspot.com/6497057/diff/3001/juju/conn.go#newcode92 juju/conn.go:92: env.Set(k, v) Aug 30 22:15:25 <niemeyer> I suspect it's ...
12 years, 10 months ago (2012-08-31 11:37:59 UTC) #4
niemeyer
Cool, I added some comments for the record, and.. well, not sure if we should ...
12 years, 10 months ago (2012-08-31 11:38:35 UTC) #5
dave_cheney.net
Sorry, this one of several failed braches thanks to prereq and branching issues, the correct ...
12 years, 10 months ago (2012-08-31 11:39:09 UTC) #6
niemeyer
Ah, nevermind.. it looks already rejected. I probably looked at out-of-date information, sorry.
12 years, 10 months ago (2012-08-31 11:40:51 UTC) #7
dave_cheney.net
12 years, 10 months ago (2012-08-31 11:41:22 UTC) #8
Sorry, maybe I should change the description on failed branches to
indicate as such.

On Fri, Aug 31, 2012 at 9:40 PM,  <n13m3y3r@gmail.com> wrote:
> Ah, nevermind.. it looks already rejected. I probably looked at
> out-of-date information, sorry.
>
> http://codereview.appspot.com/6497057/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b