juju: update unknown config attrs once

juju: update unknown config attrs once

Additional UnknownAttrs from the local environment
will only be applied if they do not already exist in
the state.

https://code.launchpad.net/~dave-cheney/juju-core/080-conn-update-secrets-only-if-needed/+merge/121979

(do not edit description out of merge proposal)

[dave_cheney.net, 2012-08-30 03:36:27]

Please take a look.

[dave_cheney.net, 2012-08-31 02:01:41]

Please take a look.

[dave_cheney.net, 2012-08-31 02:02:32]

On 2012/08/31 02:01:41, dfc wrote:
> Please take a look.

URGH - prereq fail. WIll have to submit again.

[niemeyer, 2012-08-31 11:37:59]

http://codereview.appspot.com/6497057/diff/3001/juju/conn.go
File juju/conn.go (right):

http://codereview.appspot.com/6497057/diff/3001/juju/conn.go#newcode92
juju/conn.go:92: env.Set(k, v)
Aug 30 22:15:25 <niemeyer>      I suspect it's a bit more involved than that
Aug 30 22:15:52 <niemeyer>      As the comment suggests, we should only push
secrets when they are not yet set, and should push *only* secrets

[niemeyer, 2012-08-31 11:38:35]

Cool, I added some comments for the record, and.. well, not sure if we should
close this one?

[dave_cheney.net, 2012-08-31 11:39:09]

Sorry, this one of several failed braches thanks to prereq and branching issues,
the correct version is http://codereview.appspot.com/6496069/

[niemeyer, 2012-08-31 11:40:51]

Ah, nevermind.. it looks already rejected. I probably looked at out-of-date
information, sorry.

[dave_cheney.net, 2012-08-31 11:41:22]

Sorry, maybe I should change the description on failed branches to
indicate as such.

On Fri, Aug 31, 2012 at 9:40 PM,  <n13m3y3r@gmail.com> wrote:
> Ah, nevermind.. it looks already rejected. I probably looked at
> out-of-date information, sorry.
>
> http://codereview.appspot.com/6497057/