Issue 6496103: code review 6496103: C: add Brian Slesinsky (Google CLA)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6496103: code review 6496103: C: add Brian Slesinsky (Google CLA) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by adg

Modified:
11 years, 7 months ago

Reviewers:
iant2

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

C: add Brian Slesinsky (Google CLA)

Patch Set 1 #

Patch Set 2 : diff -r 872a70417273 https://go.googlecode.com/hg #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	CONTRIBUTORS	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

11 years, 7 months ago (2012-09-11 01:24:13 UTC) #1

dsymonds

LGTM These aren't sorted any more; want to fix that at the same time?

11 years, 7 months ago (2012-09-11 01:31:47 UTC) #2

adg

*** Submitted as http://code.google.com/p/go/source/detail?r=bfa71d733e8f *** C: add Brian Slesinsky (Google CLA) R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/6496103

11 years, 7 months ago (2012-09-11 01:34:03 UTC) #3

iant2

11 years, 7 months ago (2012-09-11 03:45:53 UTC) #4

On Mon, Sep 10, 2012 at 6:24 PM,  <adg@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg
>
>
> Description:
> C: add Brian Slesinsky (Google CLA)

> Index: CONTRIBUTORS
> ===================================================================
> --- a/CONTRIBUTORS
> +++ b/CONTRIBUTORS
> @@ -79,6 +79,7 @@
>  Bobby Powers <bobbypowers@gmail.com>
>  Brad Fitzpatrick <bradfitz@golang.org> <bradfitz@gmail.com>
>  Brian Dellisanti <briandellisanti@gmail.com>
> +Brian Slesinskya <skybrian@google.com>


Typo: trailing 'a'.

Ian

Expand All Messages | Collapse All Messages