Issue 6496082: Fix build on platforms that don't support optimize

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6496082: Fix build on platforms that don't support optimize (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by TomH

Modified:
11 years, 10 months ago

Reviewers:
EricB, DerekS

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix build on platforms that don't support optimize. (Upstreamed from Clank)

Patch Set 1 #

Total comments: 2

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/opts/SkBitmapProcState_opts_arm.cpp	View		1 chunk	+1 line, -0 lines	2 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

DerekS

https://codereview.appspot.com/6496082/diff/1/src/opts/SkBitmapProcState_opts_arm.cpp File src/opts/SkBitmapProcState_opts_arm.cpp (right): https://codereview.appspot.com/6496082/diff/1/src/opts/SkBitmapProcState_opts_arm.cpp#newcode12 src/opts/SkBitmapProcState_opts_arm.cpp:12: #include "SkPreConfig.h" I don't think we usually want to ...

11 years, 10 months ago (2012-09-04 16:16:04 UTC) #3

TomH

Committed with r5385. https://codereview.appspot.com/6496082/diff/1/src/opts/SkBitmapProcState_opts_arm.cpp File src/opts/SkBitmapProcState_opts_arm.cpp (right): https://codereview.appspot.com/6496082/diff/1/src/opts/SkBitmapProcState_opts_arm.cpp#newcode12 src/opts/SkBitmapProcState_opts_arm.cpp:12: #include "SkPreConfig.h" On 2012/09/04 16:16:04, DerekS ...

11 years, 10 months ago (2012-09-04 16:25:58 UTC) #5

lgtm for the patch with SkTypes.h

Expand All Messages | Collapse All Messages