Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(598)

Issue 6496074: Removes echoed information from make doc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by PhilEHolmes
Modified:
11 years, 6 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

I've tested this with a full make, make doc, make test and diffed the files created with make doc - all is exactly the same. Think this should be good to go, but just want confirmation.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M Documentation/GNUmakefile View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5
PhilEHolmes
Please check.
11 years, 7 months ago (2012-09-02 14:29:41 UTC) #1
benko.pal
LGTM
11 years, 6 months ago (2012-09-02 18:11:08 UTC) #2
Patrick McCarty
LGTM
11 years, 6 months ago (2012-09-03 03:43:42 UTC) #3
John Mandereau
LGTM, but why is this Rietveld issue still open whereas the patch has been pushed?
11 years, 6 months ago (2012-09-06 20:46:38 UTC) #4
email_philholmes.net
11 years, 6 months ago (2012-09-07 08:07:16 UTC) #5
----- Original Message ----- 
From: <john.mandereau@gmail.com>
To: <PhilEHolmes@googlemail.com>; <benko.pal@gmail.com>; <pnorcks@gmail.com>
Cc: <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com>
Sent: Thursday, September 06, 2012 9:46 PM
Subject: Re: Removes echoed information from make doc (issue 6496074)


> LGTM, but why is this Rietveld issue still open whereas the patch has
> been pushed?
>
> http://codereview.appspot.com/6496074/

Looks closed to me.

--
Phil Holmes 

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b