Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4747)

Issue 6495135: Issue 2717: Implement \single for converting overrides to tweaks (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by dak
Modified:
11 years, 7 months ago
Reviewers:
Keith, janek, reinhold, Reinhold, reinhold
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Issue 2717: Implement \single for converting overrides to tweaks \single, like \once, can be applied to music consisting of one or more overrides. It translates such an override set, for example \easyHeadsOn, into a tweak on the following music item, so you can use it like { < \single\easyHeadsOn c' g' >2 q } inside of a chord and have it only affect a single notehead of the chord when \once\easyHeadsOn would affect all noteheads. In that manner, most overrides defined in ly/property-init.ly are made available as tweaks.

Patch Set 1 #

Patch Set 2 : Use \omit rather than \erase #

Total comments: 1

Patch Set 3 : Make \single\voiceOne work #

Patch Set 4 : Bring the amount of checking in line with the rest of the code #

Patch Set 5 : Rebase on current master #

Patch Set 6 : Reduce this issue to \single #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M ly/music-functions-init.ly View 1 2 3 4 5 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 8
Keith
Works well for me. You mis-typed something in the description because > so you can ...
11 years, 7 months ago (2012-09-24 06:34:00 UTC) #1
dak
On 2012/09/24 06:34:00, Keith wrote: > Works well for me. > > You mis-typed something ...
11 years, 7 months ago (2012-09-24 08:44:31 UTC) #2
Reinhold
is there any particular reason why you created a new command (\single) and didn't reuse ...
11 years, 7 months ago (2012-09-26 09:05:18 UTC) #3
dak
On 2012/09/26 09:05:18, Reinhold wrote: > is there any particular reason why you created a ...
11 years, 7 months ago (2012-09-26 09:26:36 UTC) #4
reinhold_kainhofer.com
On 26/09/2012 11:26, dak@gnu.org wrote: > \once does something entirely different. It does not turn ...
11 years, 7 months ago (2012-09-26 13:08:29 UTC) #5
dak
Reinhold Kainhofer <reinhold@kainhofer.com> writes: > On 26/09/2012 11:26, dak@gnu.org wrote: >> \once does something entirely ...
11 years, 7 months ago (2012-09-26 13:32:19 UTC) #6
reinhold_fam.tuwien.ac.at
On 2012-09-26 15:32, dak@gnu.org wrote: > Reinhold Kainhofer <reinhold@kainhofer.com> writes: > >> On 26/09/2012 11:26, ...
11 years, 7 months ago (2012-09-26 22:52:02 UTC) #7
janek
11 years, 7 months ago (2012-09-28 05:00:53 UTC) #8
i don't feel competent to speak about scheme code, but the idea LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b