Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3713)

Issue 6495107: Make RhythmicStaff show single notes for chords (issue 185)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by J. Rohrer
Modified:
11 years, 7 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Make RhythmicStaff show single notes for chords (issue 185) RhythmicStaff uses Pitch_squash_engraver to move all note heads to a common vertical position. With chords, at least two problems arise: (1) As all notes from one chord collide now, so some of them used to be moved aside. Hence, for each chord, two adjacent note heads would appear in the output. (2) For chords with dotted duration, Dot_column_engraver would put one dot per note head into a DotColumn, where they would be spaced apart. So for every note in the chord, one separate dot would be visible. Solve (1) by explicitly setting X-offset to 0 for squashed note heads in the Pitch_squash_engraver. Solve (2) by replacing Dot_column_engraver with a new Squashed_dot_column_engraver. This variant puts only at most one dot per time step onto a DotColumn, and marks any further ones as transparent. Update regression test rhythmic-staff.ly to include two chords.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -5 lines) Patch
M input/regression/rhythmic-staff.ly View 1 chunk +5 lines, -3 lines 0 comments Download
M lily/pitch-squash-engraver.cc View 1 chunk +9 lines, -1 line 0 comments Download
A lily/squashed-dot-column-engraver.cc View 1 chunk +88 lines, -0 lines 0 comments Download
M ly/engraver-init.ly View 1 chunk +1 line, -1 line 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b