Issue 6493073: Dynamics do not unnecessarily horizontal shift for stems.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6493073: Dynamics do not unnecessarily horizontal shift for stems. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by MikeSol

Modified:
11 years, 5 months ago

Reviewers:
Graham Percival, dak

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

Dynamics do not unnecessarily horizontal shift for stems.

Patch Set 2 : Uses Interval_t instead of vector #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -1 line)			Patch
	A	input/regression/dynamics-avoid-cross-staff-stem-2.ly	View		1 chunk	+23 lines, -0 lines	0 comments	Download
	M	lily/self-alignment-interface.cc	View	1	1 chunk	+18 lines, -1 line	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dak

http://codereview.appspot.com/6493073/diff/1/lily/self-alignment-interface.cc File lily/self-alignment-interface.cc (right): http://codereview.appspot.com/6493073/diff/1/lily/self-alignment-interface.cc#newcode213 lily/self-alignment-interface.cc:213: vector_sort (vais, less<int> ()); Seriously? If dir is UP, ...

11 years, 7 months ago (2012-09-02 16:06:30 UTC) #1

MikeSol

Thanks for the review! http://codereview.appspot.com/6493073/diff/1/lily/self-alignment-interface.cc File lily/self-alignment-interface.cc (right): http://codereview.appspot.com/6493073/diff/1/lily/self-alignment-interface.cc#newcode213 lily/self-alignment-interface.cc:213: vector_sort (vais, less<int> ()); On ...

11 years, 7 months ago (2012-09-02 16:46:24 UTC) #2

Graham Percival

http://codereview.appspot.com/6493073/diff/3001/lily/self-alignment-interface.cc File lily/self-alignment-interface.cc (right): http://codereview.appspot.com/6493073/diff/3001/lily/self-alignment-interface.cc#newcode205 lily/self-alignment-interface.cc:205: // if coll is cross staff but extremal and ...

11 years, 7 months ago (2012-09-03 19:40:20 UTC) #3

Graham Percival

11 years, 7 months ago (2012-09-03 19:41:20 UTC) #4

adds programming errors.  I've set it to patch-needs_work.

Expand All Messages | Collapse All Messages