Issue 6492105: code review 6492105: cmd/yacc: allow utf-8 token values

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6492105: code review 6492105: cmd/yacc: allow utf-8 token values (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by r

Modified:
11 years, 7 months ago

Reviewers:

CC:
golang-dev, rsc, 0xjnml

Visibility:
Public.

Description

cmd/yacc: allow utf-8 token values Also clean up the code and allow \U. Fixes issue 3007.

Patch Set 1 #

Patch Set 2 : diff -r e3fce06291ec https://code.google.com/p/go #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -54 lines)			Patch
	M	src/cmd/yacc/units.y	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
	M	src/cmd/yacc/yacc.go	View		4 chunks	+61 lines, -51 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 7 months ago (2012-09-12 16:37:58 UTC) #1

11 years, 7 months ago (2012-09-13 20:59:03 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=0d32d96b4cc1 ***

cmd/yacc: allow utf-8 token values
Also clean up the code and allow \U.
Fixes issue 3007.

R=golang-dev, rsc, 0xjnml
CC=golang-dev
http://codereview.appspot.com/6492105

Expand All Messages | Collapse All Messages