Issue 6492094: Added explicit cache clearing

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6492094: Added explicit cache clearing (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by robertphillips

Modified:
12 years, 1 month ago

Reviewers:
rileya, bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

When unlock goes away so too will all the opportunities for the cache to clear itself. This CL adds explicit purge calls at all the old unlock locations. The cache usage stats remain the same as prior to this CL.

Patch Set 1 #

Patch Set 2 : turned off cache stats #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -1 line)			Patch
M	include/gpu/GrContext.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/gpu/GrRenderTarget.cpp	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/gpu/GrResourceCache.h	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/gpu/effects/GrTextureStripAtlas.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

On 2012/09/07 18:17:34, robertphillips wrote: LGTM. Can we put a comment on ResCache and Context ...

12 years, 1 month ago (2012-09-07 19:40:24 UTC) #2

robertphillips

Added comment in http://codereview.appspot.com/6488098/

12 years, 1 month ago (2012-09-07 20:05:41 UTC) #3

committed as r5444

Expand All Messages | Collapse All Messages