Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2547)

Issue 6492094: Added explicit cache clearing (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by robertphillips
Modified:
12 years, 3 months ago
Reviewers:
rileya, bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

When unlock goes away so too will all the opportunities for the cache to clear itself. This CL adds explicit purge calls at all the old unlock locations. The cache usage stats remain the same as prior to this CL.

Patch Set 1 #

Patch Set 2 : turned off cache stats #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M include/gpu/GrContext.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M src/gpu/GrRenderTarget.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/GrResourceCache.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/gpu/effects/GrTextureStripAtlas.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4
robertphillips
12 years, 3 months ago (2012-09-07 18:17:34 UTC) #1
bsalomon
On 2012/09/07 18:17:34, robertphillips wrote: LGTM. Can we put a comment on ResCache and Context ...
12 years, 3 months ago (2012-09-07 19:40:24 UTC) #2
robertphillips
Added comment in http://codereview.appspot.com/6488098/
12 years, 3 months ago (2012-09-07 20:05:41 UTC) #3
robertphillips
12 years, 3 months ago (2012-09-07 20:06:05 UTC) #4
committed as r5444
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b