Issue 6492088: Fixed assert in unlockStencilBuffer

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6492088: Fixed assert in unlockStencilBuffer (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by robertphillips

Modified:
12 years ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

The assert in question can misfire if the app holds onto a render target (which holds onto a SB) beyond destruction of the GrContext - which is what bench does.

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/gpu/GrContext.cpp	View		2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

On 2012/09/06 14:01:36, robertphillips wrote: LGTM (since we are on the way to removing lock/unlock ...

12 years ago (2012-09-06 14:15:41 UTC) #2

committed as r5413

Expand All Messages | Collapse All Messages