Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(45)

Issue 6492065: testing: import test only deps

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by dave
Modified:
12 years, 10 months ago
Reviewers:
niemeyer, mp+122187
Visibility:
Public.

Description

testing: import test only deps This proposal makes it possible to get all the deps required to build and *test* Juju using these simple steps. This is intended to support running a CI build of Juju. sudo apt-get install gcc golang-go bzr libzookeeper-mt-dev mongodb-server zookeeperd zip -y export GOPATH=$HOME go get -v launchpad.net/juju-core/cmd/juju go test launchpad.net/juju-core/... Currently this procedure fails because go get doens't resolve these two pkgs because they are only visible from the testing path. src/launchpad.net/juju-core/testing/http.go:7:2: import "launchpad.net/gocheck": cannot find package src/launchpad.net/juju-core/store/lpad.go:7:2: import "launchpad.net/lpad": cannot find package https://code.launchpad.net/~dave-cheney/juju-core/083-testing-import-test-only-packages/+merge/122187 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : testing: import test only deps #

Patch Set 3 : testing: import test only deps #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
A testing/imports.go View 1 chunk +9 lines, -0 lines 1 comment Download

Messages

Total messages: 4
dave_cheney.net
Please take a look.
12 years, 10 months ago (2012-08-31 03:07:39 UTC) #1
dave_cheney.net
Please take a look.
12 years, 10 months ago (2012-08-31 03:12:49 UTC) #2
dave_cheney.net
Please take a look.
12 years, 10 months ago (2012-08-31 03:16:55 UTC) #3
niemeyer
12 years, 10 months ago (2012-09-04 14:20:02 UTC) #4
https://codereview.appspot.com/6492065/diff/2002/testing/imports.go
File testing/imports.go (right):

https://codereview.appspot.com/6492065/diff/2002/testing/imports.go#newcode8
testing/imports.go:8: _ "launchpad.net/lpad"
% grep 'launchpad.net/lpad' -r -l .
./store/lpad_test.go
./store/charmload/main.go
./store/lpad.go

?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b