LGTM On Fri, Sep 7, 2012 at 9:31 AM, <r@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
11 years, 7 months ago
(2012-09-07 16:38:27 UTC)
#2
LGTM
On Fri, Sep 7, 2012 at 9:31 AM, <r@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> faq: mercurial vs. git
>
> Please review this at
http://codereview.appspot.com/**6490092/<http://codereview.appspot.com/6490092/>
>
> Affected files:
> M doc/go_faq.html
>
>
> Index: doc/go_faq.html
> ==============================**==============================**=======
> --- a/doc/go_faq.html
> +++ b/doc/go_faq.html
> @@ -922,6 +922,31 @@
> for more information about how to proceed.
> </p>
>
> +<h3 id="Why_does_the_project_use_**Mercurial_and_not_git">
> +Why does the project use Mercurial and not git?</h3>
> +
> +<p>
> +The Go project, hosted by Google Code at
> +<a href="http://code.google.com/**p/go <http://code.google.com/p/go>">
> code.google.com/p/go</a>**,
> +uses Mercurial as its version control system. When the project launched,
> +Google Code supported only Subversion and Mercurial.
> +Mercurial was a better choice because of its plugin mechanism
> +that allowed us to create the "codereview" plugin to connect
> +the project to the excellent code review tools at
> +<a href="http://codereview.**appspot.com <http://codereview.appspot.com>
> ">codereview.**appspot.com <http://codereview.appspot.com></a>.
> +</p>
> +
> +<p>
> +Git is more widely installed than Mercurial, so programmers who work
> +with the Go project's source rather than release downloads sometimes
> +ask for the project to switch to git.
> +That would be possible, but it would be a lot of work and
> +would also require reimplementing the codereview plugin.
> +Given that Mercurial works today, with code review support,
> +combined with the Go project's mostly linear, non-branching use of
> +version control, a switch to git doesn't seem worthwhile.
> +</p>
> +
> <h2 id="Pointers">Pointers and Allocation</h2>
>
> <h3 id="pass_by_value">
>
>
>
LGTM On Fri, Sep 7, 2012 at 9:38 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote: > LGTM ...
11 years, 7 months ago
(2012-09-07 18:12:15 UTC)
#3
LGTM
On Fri, Sep 7, 2012 at 9:38 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> LGTM
>
>
> On Fri, Sep 7, 2012 at 9:31 AM, <r@golang.org> wrote:
>>
>> Reviewers: golang-dev_googlegroups.com,
>>
>> Message:
>> Hello golang-dev@googlegroups.com,
>>
>> I'd like you to review this change to
>> https://code.google.com/p/go
>>
>>
>> Description:
>> faq: mercurial vs. git
>>
>> Please review this at http://codereview.appspot.com/6490092/
>>
>> Affected files:
>> M doc/go_faq.html
>>
>>
>> Index: doc/go_faq.html
>> ===================================================================
>> --- a/doc/go_faq.html
>> +++ b/doc/go_faq.html
>> @@ -922,6 +922,31 @@
>> for more information about how to proceed.
>> </p>
>>
>> +<h3 id="Why_does_the_project_use_Mercurial_and_not_git">
>> +Why does the project use Mercurial and not git?</h3>
>> +
>> +<p>
>> +The Go project, hosted by Google Code at
>> +<a href="http://code.google.com/p/go">code.google.com/p/go</a>,
>> +uses Mercurial as its version control system. When the project launched,
>> +Google Code supported only Subversion and Mercurial.
>> +Mercurial was a better choice because of its plugin mechanism
>> +that allowed us to create the "codereview" plugin to connect
>> +the project to the excellent code review tools at
>> +<a href="http://codereview.appspot.com">codereview.appspot.com</a>.
>> +</p>
>> +
>> +<p>
>> +Git is more widely installed than Mercurial, so programmers who work
>> +with the Go project's source rather than release downloads sometimes
>> +ask for the project to switch to git.
>> +That would be possible, but it would be a lot of work and
>> +would also require reimplementing the codereview plugin.
>> +Given that Mercurial works today, with code review support,
>> +combined with the Go project's mostly linear, non-branching use of
>> +version control, a switch to git doesn't seem worthwhile.
>> +</p>
>> +
>> <h2 id="Pointers">Pointers and Allocation</h2>
>>
>> <h3 id="pass_by_value">
>>
>>
>
Issue 6490092: code review 6490092: faq: mercurial vs. git
(Closed)
Created 11 years, 7 months ago by r
Modified 11 years, 7 months ago
Reviewers:
Base URL:
Comments: 0