Issue 6489074: Allow direction - ^ _ before string indication \1, \2...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6489074: Allow direction - ^ _ before string indication \1, \2... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by dak

Modified:
12 years, 6 months ago

Reviewers:
janek

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

Allow direction - ^ _ before string indication \1, \2...

Patch Set 1 #

Total comments: 3

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	lily/parser.yy	View		2 chunks	+1 line, -1 line	3 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

janek

http://codereview.appspot.com/6489074/diff/1/lily/parser.yy File lily/parser.yy (right): http://codereview.appspot.com/6489074/diff/1/lily/parser.yy#newcode2457 lily/parser.yy:2457: | string_number_event Why is this now in "direction_less_event"? Does ...

12 years, 6 months ago (2012-09-04 05:56:15 UTC) #1

dak

12 years, 6 months ago (2012-09-04 08:05:42 UTC) #2

janek

12 years, 6 months ago (2012-09-04 11:48:52 UTC) #3

http://codereview.appspot.com/6489074/diff/1/lily/parser.yy
File lily/parser.yy (right):

http://codereview.appspot.com/6489074/diff/1/lily/parser.yy#newcode2457
lily/parser.yy:2457: | string_number_event
On 2012/09/04 08:05:42, dak wrote:
> No, it means that it is a post_event without a direction specifier (yet).  I
> don't see this as inaccurate.

ok.  I don't have a better name so let it be this way.

Expand All Messages | Collapse All Messages