Issue 6488130: Changes less<Grob *> to Grob::less.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6488130: Changes less<Grob *> to Grob::less. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by MikeSol

Modified:
11 years, 5 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

Changes less<Grob *> to Grob::less. less<Grob *> was sorting grobs based on the address in memory, which is probably not what any of the people using it ever intended for it to do.

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	lily/accidental-placement.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/grob-array.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/system.cc	View	1 chunk	+1 line, -1 line	0 comments	Download