code review 6488129: cmd/go: reject relative values for GOPATH

cmd/go: reject relative values for GOPATH

Fixes issue 4062.

[fss, 2012-09-14 13:12:56]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com, nicksaika@gmail.com),

I'd like you to review this change to
https://code.google.com/p/go

[dfc, 2012-09-14 13:18:48]

The rules for GOPATH are getting complicated, I think this could do with a test
of some sort in test.bash.

http://codereview.appspot.com/6488129/diff/4002/src/cmd/go/main.go
File src/cmd/go/main.go (right):

http://codereview.appspot.com/6488129/diff/4002/src/cmd/go/main.go#newcode131
src/cmd/go/main.go:131: }
if gopath := os.Getenv("GOPATH"); gopath == runtime.GOROOT() {
   fmt.Fprintf(os.Stderr, "warning: GOPATH set to GOROOT (%s) has no effect\n",
gopath)
} else if build.IsLocalImport(gopath) {
   fmt.Fprintf(os.Stderr, "go: GOPATH cannot be relative.\nRun 'go help gopath'
for usage.\n")
   os.Exit(2)
}

[fss, 2012-09-14 13:30:20]

Please take another look.

https://codereview.appspot.com/6488129/diff/4002/src/cmd/go/main.go
File src/cmd/go/main.go (right):

https://codereview.appspot.com/6488129/diff/4002/src/cmd/go/main.go#newcode131
src/cmd/go/main.go:131: }
On 2012/09/14 13:18:48, dfc wrote:
> if gopath := os.Getenv("GOPATH"); gopath == runtime.GOROOT() {
>    fmt.Fprintf(os.Stderr, "warning: GOPATH set to GOROOT (%s) has no
effect\n",
> gopath)
> } else if build.IsLocalImport(gopath) {
>    fmt.Fprintf(os.Stderr, "go: GOPATH cannot be relative.\nRun 'go help
gopath'
> for usage.\n")
>    os.Exit(2)
> }

Done.

[r, 2012-09-14 16:01:40]

https://codereview.appspot.com/6488129/diff/3/src/cmd/go/main.go
File src/cmd/go/main.go (right):

https://codereview.appspot.com/6488129/diff/3/src/cmd/go/main.go#newcode130
src/cmd/go/main.go:130: } else if build.IsLocalImport(gopath) {
This won't catch
GOPATH=:/home/x:.

[fss, 2012-09-14 20:16:03]

Hello rsc@golang.org, dave@cheney.net, r@golang.org (cc:
golang-dev@googlegroups.com, nicksaika@gmail.com),

Please take another look.

[r, 2012-09-14 21:10:53]

http://codereview.appspot.com/6488129/diff/16001/src/cmd/go/main.go
File src/cmd/go/main.go (right):

http://codereview.appspot.com/6488129/diff/16001/src/cmd/go/main.go#newcode133
src/cmd/go/main.go:133: fmt.Fprintf(os.Stderr, "go: GOPATH cannot be
relative.\nRun 'go help gopath' for usage.\n")
include the name of the offending entry.
go: GOPATH entry is relative; must be absolute path: %q

[fss, 2012-09-14 22:22:21]

PTAL

https://codereview.appspot.com/6488129/diff/16001/src/cmd/go/main.go
File src/cmd/go/main.go (right):

https://codereview.appspot.com/6488129/diff/16001/src/cmd/go/main.go#newcode133
src/cmd/go/main.go:133: fmt.Fprintf(os.Stderr, "go: GOPATH cannot be
relative.\nRun 'go help gopath' for usage.\n")
On 2012/09/14 21:10:53, r wrote:
> include the name of the offending entry.
> go: GOPATH entry is relative; must be absolute path: %q

Done.

[r, 2012-09-14 22:26:49]

LGTM

[r, 2012-09-17 20:44:59]

*** Submitted as http://code.google.com/p/go/source/detail?r=0f69762cebd1 ***

cmd/go: reject relative values for GOPATH

Fixes issue 4062.

R=rsc, dave, r
CC=golang-dev, nicksaika
http://codereview.appspot.com/6488129

Committer: Rob Pike <r@golang.org>