Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(509)

Issue 6488111: Removed access of freed memory in GrContext dtor (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by robertphillips
Modified:
12 years, 1 month ago
Reviewers:
EricB, bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

So ... in ~GrContext when the gpu is freed (after the resource cache has been freed), some lingering render targets (and their associated stencil buffers) can be freed. GrRenderTarget::setStencilBuffer (called in GrRenderTarget::onRelease) makes a call to GrContext::purgeCache which accessed the already freed resource cache.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/gpu/GrContext.cpp View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 4
robertphillips
12 years, 1 month ago (2012-09-11 11:53:07 UTC) #1
EricB
Again, LGTM but I don't know this code.
12 years, 1 month ago (2012-09-11 12:00:14 UTC) #2
bsalomon
On 2012/09/11 12:00:14, EricB wrote: > Again, LGTM but I don't know this code. LGTM
12 years, 1 month ago (2012-09-11 12:32:27 UTC) #3
robertphillips
12 years, 1 month ago (2012-09-11 13:01:49 UTC) #4
committed as r5479
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b