code review 6488059: codereview.py: Better error handling.

codereview.py: Better error handling.

Raise Abort() exceptions instead of returning strings that are converted into Abort()s by the hgcommand() decorator.

This gives us back proper error messages for incorrect number of arguments.

Left a 'dummy' hgcommand decorator in place as a way to document what functions are hg commands, and just in case we need some other kind of hack in the future.

[luriel, 2012-08-31 07:51:55]

Hello adg@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2012-09-01 14:21:29]

Please complete a CLA as described at
http://golang.org/doc/contribute.html#copyright.

Thanks.
Russ

[rsc, 2012-09-01 23:55:42]

*** Submitted as http://code.google.com/p/go/source/detail?r=6d3a917d2b85 ***

codereview.py: correct error handling without decorator

The decorator hides the number of function arguments from Mercurial,
so Mercurial cannot give proper error messages about commands
invoked with the wrong number of arguments.

Left a 'dummy' hgcommand decorator in place as a way to document
what functions are hg commands, and just in case we need some other
kind of hack in the future.

R=adg, rsc
CC=golang-dev
http://codereview.appspot.com/6488059

Committer: Russ Cox <rsc@golang.org>

[luriel, 2012-09-21 11:03:10]

*** Abandoned ***

[luriel, 2012-09-21 11:46:27]

Please ignore this, some hg command told me to run hg change -d for
unknown reasons, and i foolishly listened to it.

On Fri, Sep 21, 2012 at 1:03 PM,  <uriel@berlinblue.org> wrote:
> *** Abandoned ***
>
> http://codereview.appspot.com/6488059/