LGTM http://codereview.appspot.com/6486046/diff/2001/apiclient/http.py File apiclient/http.py (right): http://codereview.appspot.com/6486046/diff/2001/apiclient/http.py#newcode569 apiclient/http.py:569: Blank line. http://codereview.appspot.com/6486046/diff/2001/apiclient/http.py#newcode581 apiclient/http.py:581: # The data left available to read sits in [cur, end) Unmatched [,) http://codereview.appspot.com/6486046/diff/2001/tests/test_http.py File tests/test_http.py (right): http://codereview.appspot.com/6486046/diff/2001/tests/test_http.py#newcode790 tests/test_http.py:790: class TestStreamSlice(unittest.TestCase): Docstring for at least the class, please.
http://codereview.appspot.com/6486046/diff/2001/apiclient/http.py File apiclient/http.py (right): http://codereview.appspot.com/6486046/diff/2001/apiclient/http.py#newcode569 apiclient/http.py:569: On 2012/08/22 18:26:35, Ali Afshar wrote: > Blank line. Done. http://codereview.appspot.com/6486046/diff/2001/apiclient/http.py#newcode581 apiclient/http.py:581: # The data left available to read sits in [cur, end) That's not a typo, it's a half-open interval. On 2012/08/22 18:26:35, Ali Afshar wrote: > Unmatched [,) http://codereview.appspot.com/6486046/diff/2001/tests/test_http.py File tests/test_http.py (right): http://codereview.appspot.com/6486046/diff/2001/tests/test_http.py#newcode790 tests/test_http.py:790: class TestStreamSlice(unittest.TestCase): On 2012/08/22 18:26:35, Ali Afshar wrote: > Docstring for at least the class, please. Done.
Committed in http://code.google.com/p/google-api-python-client/source/detail?r=31d948daf0a... On 2012/08/22 20:30:31, jcgregorio_google wrote: > http://codereview.appspot.com/6486046/diff/2001/apiclient/http.py > File apiclient/http.py (right): > > http://codereview.appspot.com/6486046/diff/2001/apiclient/http.py#newcode569 > apiclient/http.py:569: > On 2012/08/22 18:26:35, Ali Afshar wrote: > > Blank line. > > Done. > > http://codereview.appspot.com/6486046/diff/2001/apiclient/http.py#newcode581 > apiclient/http.py:581: # The data left available to read sits in [cur, end) > That's not a typo, it's a half-open interval. > > On 2012/08/22 18:26:35, Ali Afshar wrote: > > Unmatched [,) > > http://codereview.appspot.com/6486046/diff/2001/tests/test_http.py > File tests/test_http.py (right): > > http://codereview.appspot.com/6486046/diff/2001/tests/test_http.py#newcode790 > tests/test_http.py:790: class TestStreamSlice(unittest.TestCase): > On 2012/08/22 18:26:35, Ali Afshar wrote: > > Docstring for at least the class, please. > > Done.
lgtm