Issue 6486043: Add gpu.gypi to ease skia->chrome rolls

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6486043: Add gpu.gypi to ease skia->chrome rolls (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by bsalomon

Modified:
12 years, 2 months ago

Reviewers:
epoger, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : fix indent #

Total comments: 1

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+279 lines, -233 lines)			Patch
	M	gyp/gpu.gyp	View	1	4 chunks	+19 lines, -233 lines	1 comment	Download
	A	gyp/gpu.gypi	View		1 chunk	+260 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

Chrome and perhaps other clients do not care at all about the GrGLInterface factories and ...

12 years, 2 months ago (2012-08-22 15:08:03 UTC) #1

robertphillips

LGTM - do we still need the 'gr' 'skgr' split? http://codereview.appspot.com/6486043/diff/2001/gyp/gpu.gyp File gyp/gpu.gyp (right): http://codereview.appspot.com/6486043/diff/2001/gyp/gpu.gyp#newcode113 ...

12 years, 2 months ago (2012-08-22 15:48:03 UTC) #2

bsalomon

12 years, 2 months ago (2012-08-23 13:45:57 UTC) #4

I don't think we care about the skgr/gr distinction anymore. My only hesitation
about combining them is naming conventions. 

Closed with 5250.

Expand All Messages | Collapse All Messages