Refactored GrDLinkedList into SkTDLinkedList

This CL cleans up the GrDLinkedList and prepares for use in other classes.

[bsalomon, 2012-08-22 14:47:19]

What do you think of using a wrapper to the ptrs that initializes them to NULL
instead of requiring the INIT_DLINKEDLIST macro?

template <typename T> class PtrWrapper {
  public:
      PtrWrapper() : fPtr(NULL) {}
      PtrWrapper& operator =(T* ptr) { fPtr = ptr; return *this; }
      operator T*() const { return fPtr; }
      T* operator->() { return fPtr; }
  private:
      T* fPtr;
};

http://codereview.appspot.com/6484045/diff/1/include/core/SkTDLinkedList.h
File include/core/SkTDLinkedList.h (right):

http://codereview.appspot.com/6484045/diff/1/include/core/SkTDLinkedList.h#ne...
include/core/SkTDLinkedList.h:18: #define
DEFINE_DLINKEDLIST_INTERFACE(ClassName)                 \
I think the macros should be SK_...

http://codereview.appspot.com/6484045/diff/1/include/core/SkTDLinkedList.h#ne...
include/core/SkTDLinkedList.h:114: T* fHead;
Do we want these to be public?

[robertphillips, 2012-08-22 15:42:02]

http://codereview.appspot.com/6484045/diff/1/include/core/SkTDLinkedList.h
File include/core/SkTDLinkedList.h (right):

http://codereview.appspot.com/6484045/diff/1/include/core/SkTDLinkedList.h#ne...
include/core/SkTDLinkedList.h:18: #define
DEFINE_DLINKEDLIST_INTERFACE(ClassName)                 \
On 2012/08/22 14:47:20, bsalomon wrote:
> I think the macros should be SK_...

Done.

http://codereview.appspot.com/6484045/diff/1/include/core/SkTDLinkedList.h#ne...
include/core/SkTDLinkedList.h:114: T* fHead;
Done. We do need to allow some access to allow iteration.

[bsalomon, 2012-08-22 15:51:12]

http://codereview.appspot.com/6484045/diff/5001/include/core/SkTDLinkedList.h
File include/core/SkTDLinkedList.h (right):

http://codereview.appspot.com/6484045/diff/5001/include/core/SkTDLinkedList.h...
include/core/SkTDLinkedList.h:36:
SkDEBUGCODE(SkPtrWrapper<SkTDLinkedList<ClassName>> fList;) \
>> doesn't cause a problem?

http://codereview.appspot.com/6484045/diff/5001/src/gpu/GrResourceCache.cpp
File src/gpu/GrResourceCache.cpp (right):

http://codereview.appspot.com/6484045/diff/5001/src/gpu/GrResourceCache.cpp#n...
src/gpu/GrResourceCache.cpp:383: entry = entry->fPrev) {
It seems like GrResourceCache only can iterate b/c it's friends with
GrResourceEntry. Do we need an SkTDLinkedList::Iter?

[robertphillips, 2012-08-22 18:39:21]

http://codereview.appspot.com/6484045/diff/5001/include/core/SkTDLinkedList.h
File include/core/SkTDLinkedList.h (right):

http://codereview.appspot.com/6484045/diff/5001/include/core/SkTDLinkedList.h...
include/core/SkTDLinkedList.h:36:
SkDEBUGCODE(SkPtrWrapper<SkTDLinkedList<ClassName>> fList;) \
On 2012/08/22 15:51:12, bsalomon wrote:
> >> doesn't cause a problem?

Not on Windows.

http://codereview.appspot.com/6484045/diff/5001/src/gpu/GrResourceCache.cpp
File src/gpu/GrResourceCache.cpp (right):

http://codereview.appspot.com/6484045/diff/5001/src/gpu/GrResourceCache.cpp#n...
src/gpu/GrResourceCache.cpp:383: entry = entry->fPrev) {
On 2012/08/22 15:51:12, bsalomon wrote:
> It seems like GrResourceCache only can iterate b/c it's friends with
> GrResourceEntry. Do we need an SkTDLinkedList::Iter?

Done.

[bsalomon, 2012-08-22 19:59:54]

LGTM

[robertphillips, 2012-08-23 11:14:29]

committed as r5247

[reed1, 2012-08-27 16:41:05]

can this be in src/core instead of include/core ?

[robertphillips, 2012-08-31 19:50:56]

It is currently used in src/gpu and I just added a use in include/gpu. I could
move it to include/gpu but the thought was that you might use it for your
SkSurface system.