Issue 6478050: Issue 2366: THANKS needs updating or deleting

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6478050: Issue 2366: THANKS needs updating or deleting (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by dak

Modified:
11 years, 8 months ago

Reviewers:
colinpkcampbell

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

Issue 2366: THANKS needs updating or deleting This is a superficial update of THANKS. It is a temporary measure for the sake of a stable release with minimally invasive changes.

Patch Set 1 #

Total comments: 2

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -0 lines)			Patch
	M	THANKS	View		1 chunk	+70 lines, -0 lines	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Colin Campbell

http://codereview.appspot.com/6478050/diff/1/THANKS File THANKS (right): http://codereview.appspot.com/6478050/diff/1/THANKS#newcode15 THANKS:15: Benkő Pál I believe that Pál is his given ...

11 years, 8 months ago (2012-08-24 04:11:53 UTC) #1

dak

11 years, 8 months ago (2012-08-24 08:03:53 UTC) #2

http://codereview.appspot.com/6478050/diff/1/THANKS
File THANKS (right):

http://codereview.appspot.com/6478050/diff/1/THANKS#newcode15
THANKS:15: Benkő Pál
On 2012/08/24 04:11:53, Colin Campbell wrote:
> I believe that Pál is his given name and Benkő his surname.

This is basically the outcome of "git shortlog", see issue 2528 for the
discussion then.  If it keeps upsetting people, Pál would not apparently mind if
we change this around, but I'll keep this for now, even though the alphabetic
sorting is, indeed, off.  But that is not better for Łukasz.

Expand All Messages | Collapse All Messages