Issue 6478047: [oauth issue 50] Add AuthorizationCodeFlow.Builder.setAuthorizationServerEncodedUrl

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6478047: [oauth issue 50] Add AuthorizationCodeFlow.Builder.setAuthorizationServerEncodedUrl (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by yanivi

Modified:
11 years, 8 months ago

Reviewers:
rmistry

Base URL:
https://google-oauth-java-client.googlecode.com/hg/

Visibility:
Public.

Patch Set 2 : @since 1.11 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+135 lines, -22 lines)			Patch
	M	google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/AuthorizationCodeFlow.java	View	1	7 chunks	+135 lines, -22 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rmistry

LGTM http://codereview.appspot.com/6478047/diff/1/google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/AuthorizationCodeFlow.java File google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/AuthorizationCodeFlow.java (right): http://codereview.appspot.com/6478047/diff/1/google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/AuthorizationCodeFlow.java#newcode452 google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/AuthorizationCodeFlow.java:452: * </p> @since 1.11 and similarly below

11 years, 8 months ago (2012-08-23 12:44:47 UTC) #2

yanivi

11 years, 8 months ago (2012-08-23 13:53:11 UTC) #3

submitting...

http://codereview.appspot.com/6478047/diff/1/google-oauth-client/src/main/jav...
File
google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/AuthorizationCodeFlow.java
(right):

http://codereview.appspot.com/6478047/diff/1/google-oauth-client/src/main/jav...
google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/AuthorizationCodeFlow.java:452:
* </p>
On 2012/08/23 12:44:47, rmistry wrote:
> @since 1.11 and similarly below

Done.

Expand All Messages | Collapse All Messages